Home » Mailing list archives » linux-kernel » 2008 » January » 21

[PATCH 41/58] [GFS2] Function meta_read optimization

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: <swhiteho@...>
To: <linux-kernel@...>, <cluster-devel@...>
Cc: Bob Peterson <rpeterso@...>, Steven Whitehouse <swhiteho@...>
Subject: [PATCH 41/58] [GFS2] Function meta_read optimization
Date: Monday, January 21, 2008 - 5:21 am

From: Bob Peterson <rpeterso@redhat.com>

This patch optimizes function gfs2_meta_read.  Basically, gfs2_meta_wait
was being called regardless of whether a disk read was requested.
This just pulls that wait into the if that triggers the read.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index 9688785..bc28bc6 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -222,13 +222,14 @@ int gfs2_meta_read(struct gfs2_glock *gl, u64 blkno, int flags,
 		   struct buffer_head **bhp)
 {
 	*bhp = getbuf(gl, blkno, CREATE);
-	if (!buffer_uptodate(*bhp))
+	if (!buffer_uptodate(*bhp)) {
 		ll_rw_block(READ_META, 1, bhp);
-	if (flags & DIO_WAIT) {
-		int error = gfs2_meta_wait(gl->gl_sbd, *bhp);
-		if (error) {
-			brelse(*bhp);
-			return error;
+		if (flags & DIO_WAIT) {
+			int error = gfs2_meta_wait(gl->gl_sbd, *bhp);
+			if (error) {
+				brelse(*bhp);
+				return error;
+			}
 		}
 	}
 
-- 
1.5.1.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GFS2] Pre-pull patch posting, , (Mon Jan 21, 5:21 am)
[PATCH 01/58] [GFS2] Handle multiple glock demote requests, , (Mon Jan 21, 5:21 am)
[PATCH 02/58] [GFS2] Clean up internal read function, , (Mon Jan 21, 5:21 am)
[PATCH 03/58] [GFS2] Use -&gt;page_mkwrite() for mmap(), , (Mon Jan 21, 5:21 am)
[PATCH 04/58] [GFS2] Remove useless i_cache from inodes, , (Mon Jan 21, 5:21 am)
[PATCH 05/58] [GFS2] Remove unused field in struct gfs2_inode, , (Mon Jan 21, 5:21 am)
[PATCH 06/58] [GFS2] Add gfs2_is_writeback(), , (Mon Jan 21, 5:21 am)
[PATCH 07/58] [GFS2] Introduce gfs2_set_aops(), , (Mon Jan 21, 5:21 am)
[PATCH 08/58] [GFS2] Split gfs2_writepage into three cases, , (Mon Jan 21, 5:21 am)
[PATCH 09/58] [GFS2] Add writepages for GFS2 jdata, , (Mon Jan 21, 5:21 am)
[PATCH 10/58] [GFS2] Don't hold page lock when starting tran..., , (Mon Jan 21, 5:21 am)
[PATCH 11/58] [GFS2] Use correct include file in ops_address.c, , (Mon Jan 21, 5:21 am)
[PATCH 12/58] [GFS2] Remove unused variables, , (Mon Jan 21, 5:21 am)
[PATCH 13/58] [GFS2] Remove "reclaim limit", , (Mon Jan 21, 5:21 am)
[PATCH 14/58] [GFS2] Add sync_page to metadata address space..., , (Mon Jan 21, 5:21 am)
[PATCH 15/58] [GFS2] Reorder writeback for glock sync, , (Mon Jan 21, 5:21 am)
[PATCH 16/58] [GFS2] Remove flags no longer required, , (Mon Jan 21, 5:21 am)
[PATCH 17/58] [GFS2] Given device ID rather than s_id in "id..., , (Mon Jan 21, 5:21 am)
[PATCH 18/58] [GFS2] check kthread_should_stop when waiting, , (Mon Jan 21, 5:21 am)
[PATCH 19/58] [GFS2] Don't add glocks to the journal, , (Mon Jan 21, 5:21 am)
[PATCH 20/58] [GFS2] Use atomic_t for journal free blocks co..., , (Mon Jan 21, 5:21 am)
[PATCH 21/58] [GFS2] Move gfs2_logd into log.c, , (Mon Jan 21, 5:21 am)
[PATCH 22/58] [GFS2] Don't periodically update the jindex, , (Mon Jan 21, 5:21 am)
[PATCH 23/58] [GFS2] Check for installation of mount helpers..., , (Mon Jan 21, 5:21 am)
[PATCH 24/58] [GFS2] tidy up error message, , (Mon Jan 21, 5:21 am)
[PATCH 25/58] [GFS2] Fix runtime issue with UP kernels, , (Mon Jan 21, 5:21 am)
[PATCH 26/58] [GFS2] Revise gfs2_logd and flush thresholds, , (Mon Jan 21, 5:21 am)
[PATCH 27/58] [GFS2] remove unnecessary permission checks, , (Mon Jan 21, 5:21 am)
[PATCH 28/58] [GFS2] Fix build warnings, , (Mon Jan 21, 5:21 am)
[PATCH 29/58] [GFS2] Remove unrequired code, , (Mon Jan 21, 5:21 am)
[PATCH 30/58] [GFS2] Remove lock methods for lock_nolock pro..., , (Mon Jan 21, 5:21 am)
[PATCH 31/58] [GFS2] patch to check for recursive lock reque..., , (Mon Jan 21, 5:21 am)
[PATCH 32/58] [GFS2] Remove unused variable, , (Mon Jan 21, 5:21 am)
[PATCH 33/58] [GFS2] use pid for plock owner for nfs clients, , (Mon Jan 21, 5:21 am)
[PATCH 34/58] [GFS2] Remove function gfs2_get_block, , (Mon Jan 21, 5:21 am)
[PATCH 35/58] [GFS2] Fix typo in log.c, , (Mon Jan 21, 5:21 am)
[PATCH 36/58] [GFS2] Journal extent mapping, , (Mon Jan 21, 5:21 am)
[PATCH 37/58] [GFS2] Get rid of useless "found" variable in ..., , (Mon Jan 21, 5:21 am)
[PATCH 38/58] [GFS2] Run through full bitmaps quicker in gfs..., , (Mon Jan 21, 5:21 am)
[PATCH 39/58] [GFS2] Reorganize function gfs2_glmutex_lock, , (Mon Jan 21, 5:21 am)
[PATCH 40/58] [GFS2] Only fetch the dinode once in block_map, , (Mon Jan 21, 5:21 am)
[PATCH 41/58] [GFS2] Function meta_read optimization, , (Mon Jan 21, 5:21 am)
[PATCH 42/58] [GFS2] Incremental patch to fix compiler warning, , (Mon Jan 21, 5:22 am)
[PATCH 43/58] [GFS2] Eliminate the no longer needed sd_statf..., , (Mon Jan 21, 5:22 am)
[PATCH 44/58] [GFS2] Minor correction, , (Mon Jan 21, 5:22 am)
[PATCH 45/58] [GFS2] Fix log block mapper, , (Mon Jan 21, 5:22 am)
[PATCH 46/58] [GFS2] Remove unused variable, , (Mon Jan 21, 5:22 am)
[PATCH 47/58] [GFS2] Allow page migration for writeback and ..., , (Mon Jan 21, 5:22 am)
[PATCH 48/58] [GFS2] Initialize extent_list earlier, , (Mon Jan 21, 5:22 am)
[PATCH 49/58] [GFS2] Fix problems relating to execution of f..., , (Mon Jan 21, 5:22 am)
[PATCH 50/58] [GFS2] Fix assert in log code, , (Mon Jan 21, 5:22 am)
[PATCH 51/58] [GFS2] Reduce inode size by moving i_alloc out..., , (Mon Jan 21, 5:22 am)
[PATCH 52/58] [GFS2] Remove unneeded i_spin, , (Mon Jan 21, 5:22 am)
[PATCH 53/58] [GFS2] gfs2_alloc_required performance, , (Mon Jan 21, 5:22 am)
[PATCH 54/58] [GFS2] Fix write alloc required shortcut calcu..., , (Mon Jan 21, 5:22 am)
[PATCH 55/58] [GFS2] Fix typo, , (Mon Jan 21, 5:22 am)
[PATCH 56/58] [GFS2] Fix page_mkwrite truncation race path, , (Mon Jan 21, 5:22 am)
[PATCH 57/58] [GFS2] Lockup on error, , (Mon Jan 21, 5:22 am)
[PATCH 58/58] [GFS2] Allow journal recovery on read-only mount, , (Mon Jan 21, 5:22 am)