Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matthew Wilcox <matthew@...>
Cc: James Bottomley <James.Bottomley@...>, Ingo Molnar <mingo@...>, <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Wednesday, January 2, 2008 - 3:57 pm

On Wed, 2 Jan 2008, Matthew Wilcox wrote:

Why do you think that REQ_TYPE_BLOCK_PC has anything to do with SG?

It has *nothing* to do with SG, and anybody who uses SG in this day and 
age on a block device is just crazy. 

The way you do generic SCSI commands (on perfectly normal block device 
nodes) is using the SCSI ioctl() interfaces.  That's how you are supposed 
to do things like burn DVD's or do any kind of special ops.

So REQ_TYPE_BLOCK_PC does quite commonly happen on perfectly regular block 
devices, it's how all commands that aren't pure reads or writes done by 
the kernel behave.

If you actually use /dev/sg*, you will be using the SG driver, and if you 
don't want that to have a ->done callback, then just set "done" to NULL 
for sg_driver.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done", Linus Torvalds, (Wed Jan 2, 3:57 pm)