On Wed, 2 Jan 2008, James Bottomley wrote:It's totally immaterial if we have one reporter or many. The fact is, that thing has been outstanding for almost two months now. The root cause is almost certainly known (and Matthew is apparently even aware of it), but it has been dicked-around-with by having totally weak excuses ("is it an ide-scsi thing?") No, the correct thing would have been to fix it a month ago. By now, it needs to either have a patch, or to be reverted. It's too late to make excuses. And no, it doesn't really need any more reporters or ways to reproduce it, all it needs is looking at the patch and seeing what the differences are AT A SOURCE level. And quite frankly, I see one huge honking difference, which is that new test for if (cmd->request->cmd_type != REQ_TYPE_BLOCK_PC) which will disable all the crud that sd_done() does. And guess what? Look at what sd_done() does: it checks whether the request was partially filled, and tries to handle that end-of-medium case nicely. Which is *exactly* what seems to have broken. So I think you are making totally idiotic excuses. I may not know the SCSI layer all that intimately, and maybe I'm wrong and there is some other cause for this, but quite frankly, I doubt it. And I can look at just the patch and have a damn good idea of why something is broken, but I can't actually fix it myself because I don't know how to look up a a "scsi_driver" from a "scsi_cmnd" sanely. But almost two months after the fact, we should have had a patch that does that, or we should revert it. NO MORE BOGUS EXCUSES! Linus --
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| Tarkan Erimer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| James Bottomley | Re: Announce: Linux-next (Or Andrew's dream :-)) |
| Michal Piotrowski | Re: 2.6.21-rc5-mm4 |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Frans Pop | svc: failed to register lockdv1 RPC service (errno 97). |
| Lovich, Vitali | RE: [PATCH] Packet socket: mmapped IO: PACKET_TX_RING |
git: | |
