Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Anton Salikhmetov <salikhmetov@...>

Cc: Miklos Szeredi <miklos@...>, <peterz@...>, <linux-mm@...>, <jakob@...>, <linux-kernel@...>, <valdis.kletnieks@...>, <riel@...>, <ksm@...>, <staubach@...>, <jesper.juhl@...>, <akpm@...>, <protasnb@...>, <r.e.wolff@...>, <hidave.darkstar@...>, <hch@...>

Subject: Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

Date: Friday, January 18, 2008 - 5:27 pm

On Sat, 19 Jan 2008, Anton Salikhmetov wrote:
quoted text> 
> Before using pte_wrprotect() the vma_wrprotect() routine uses the
> pte_offset_map_lock() macro to get the PTE and to acquire the ptl
> spinlock. Why did you say that this code was not SMP-safe? It should
> be atomic, I think.

It's atomic WITH RESPECT TO OTHER PEOPLE WHO GET THE LOCK.

Guess how much another x86 CPU cares when it sets the accessed bit in 
hardware?

quoted text> The POSIX standard requires the ctime and mtime stamps to be updated
> not later than at the second call to msync() with the MS_ASYNC flag.

.. and that is no excuse for bad code.

			Linus
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH -v6 0/2] Fixing the issue with memory-mapped file times, Anton Salikhmetov, (Thu Jan 17, 6:31 pm)

Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Miklos Szeredi, (Fri Jan 18, 5:40 am)

Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Anton Salikhmetov, (Fri Jan 18, 3:48 pm)

Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Miklos Szeredi, (Sat Jan 19, 6:45 am)

Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Anton Salikhmetov, (Fri Jan 18, 6:31 am)

[PATCH -v6 2/2] Updating ctime and mtime for memory-mapped f..., Anton Salikhmetov, (Thu Jan 17, 6:31 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 5:51 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 6:15 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 6:38 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 7:00 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 7:17 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 7:23 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 7:36 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 6:25 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 1:58 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 2:11 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 2:43 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 2:57 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 3:08 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 3:22 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 3:35 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Ingo Oeser, (Fri Jan 18, 6:32 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 6:47 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Staubach, (Mon Jan 21, 10:25 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Mon Jan 21, 10:36 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Rik van Riel, (Fri Jan 18, 6:54 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Matt Mackall, (Fri Jan 18, 8:50 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Sat Jan 19, 6:22 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Matt Mackall, (Sat Jan 19, 11:49 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Rik van Riel, (Sat Jan 19, 12:25 am)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 3:58 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 4:22 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 5:03 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 5:27 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 6:04 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 6:21 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 6:35 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Rik van Riel, (Fri Jan 18, 2:28 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 2:51 pm)

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 6:39 am)

[PATCH -v6 1/2] Massive code cleanup of sys_msync(), Anton Salikhmetov, (Thu Jan 17, 6:31 pm)

Re: [PATCH -v6 1/2] Massive code cleanup of sys_msync(), Miklos Szeredi, (Fri Jan 18, 5:33 am)

Re: [PATCH -v6 1/2] Massive code cleanup of sys_msync(), Anton Salikhmetov, (Fri Jan 18, 6:30 am)

Navigation

Popular discussions


linux-kernel:
Davide Libenzi	Re: [patch 7/8] fdmap v2 - implement sys_socket2
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Mariusz Kozlowski	[KJ PATCHES] mostly kmalloc + memset conversion to k[cz]alloc
git:

linux-netdev:
KOSAKI Motohiro	[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Stefan Richter	Re: [GIT]: Networking
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 0/37] dccp: Feature negotiation - last call for comments
git-commits-head:

Colocation donated by:

Online users

Syndicate