Home » Mailing list archives » linux-kernel » 2008 » January » 18

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Miklos Szeredi <miklos@...>
Cc: <peterz@...>, <salikhmetov@...>, <linux-mm@...>, <jakob@...>, <linux-kernel@...>, <valdis.kletnieks@...>, <riel@...>, <ksm@...>, <staubach@...>, <jesper.juhl@...>, <akpm@...>, <protasnb@...>, <r.e.wolff@...>, <hidave.darkstar@...>, <hch@...>
Subject: Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files
Date: Friday, January 18, 2008 - 2:43 pm

On Fri, 18 Jan 2008, Miklos Szeredi wrote:

Yeah, that would be bad. We probably have flags free, but those page flags 
are always a pain. Scratch that.

How about just setting a per-vma dirty flag, and then instead of updating 
the mtime when taking the dirty-page fault, we just set that flag?

Then, on unmap and msync, we just do

	if (vma->dirty-flag) {
		vma->dirty_flag = 0;
		update_file_times(vma->vm_file);
	}

and be done with it? 
		

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH -v6 0/2] Fixing the issue with memory-mapped file times, Anton Salikhmetov, (Thu Jan 17, 6:31 pm)
Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Miklos Szeredi, (Fri Jan 18, 5:40 am)
Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Anton Salikhmetov, (Fri Jan 18, 3:48 pm)
Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Miklos Szeredi, (Sat Jan 19, 6:45 am)
Re: [PATCH -v6 0/2] Fixing the issue with memory-mapped file..., Anton Salikhmetov, (Fri Jan 18, 6:31 am)
[PATCH -v6 2/2] Updating ctime and mtime for memory-mapped f..., Anton Salikhmetov, (Thu Jan 17, 6:31 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 5:51 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 6:15 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 6:38 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 7:00 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 7:17 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 7:23 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 7:36 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Zijlstra, (Fri Jan 18, 6:25 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 1:58 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 2:11 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 2:43 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 2:57 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 3:08 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 3:22 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 3:35 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Ingo Oeser, (Fri Jan 18, 6:32 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 6:47 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Peter Staubach, (Mon Jan 21, 10:25 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Mon Jan 21, 10:36 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Rik van Riel, (Fri Jan 18, 6:54 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Matt Mackall, (Fri Jan 18, 8:50 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Sat Jan 19, 6:22 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Matt Mackall, (Sat Jan 19, 11:49 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Rik van Riel, (Sat Jan 19, 12:25 am)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 3:58 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 4:22 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 5:03 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 5:27 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 6:04 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Linus Torvalds, (Fri Jan 18, 6:21 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 6:35 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Rik van Riel, (Fri Jan 18, 2:28 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Miklos Szeredi, (Fri Jan 18, 2:51 pm)
Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapp..., Anton Salikhmetov, (Fri Jan 18, 6:39 am)
[PATCH -v6 1/2] Massive code cleanup of sys_msync(), Anton Salikhmetov, (Thu Jan 17, 6:31 pm)
Re: [PATCH -v6 1/2] Massive code cleanup of sys_msync(), Miklos Szeredi, (Fri Jan 18, 5:33 am)
Re: [PATCH -v6 1/2] Massive code cleanup of sys_msync(), Anton Salikhmetov, (Fri Jan 18, 6:30 am)