Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_attr patch series v3)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andi Kleen <ak@...>
Cc: <linux-kernel@...>, <tglx@...>, <jbeulich@...>, <venkatesh.pallipadi@...>
Date: Friday, January 18, 2008 - 11:56 am

* Ingo Molnar <mingo@elte.hu> wrote:


hm, and your CPA queue is no bisectable, due to:

  Subject: Undo pat cpa patch
  From: Andi Kleen <ak@suse.de>

  Going to implement this differently

    commit 5ec5c5a2302ca8794da03f8bedec931a2a814ae9
    Author: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
    Date:   Tue Jan 15 09:36:03 2008 +0100

       patches/x86-pat-cpa_i386.patch

could you please make your queue bisectable?

Also, did you actually try to port your queue ontop of the cleanups 
patch? There's an easy technique: first do an undo patch, then apply 
your patch, then apply the re-do patch. Whatever rejects come from the 
re-do patch can be dropped from the cleanup. Continue with this until 
all patches are covered. Then generate the undo+your-old-patch+redo 
patch into a single your-new-patch.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Fri Jan 18, 11:56 am)
[PATCH] [35/36] Remove set_kernel_exec, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [36/36] Clean up pte_exec, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [14/36] CPA: Add simple self test at boot, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [10/36] Add pte_pgprot on i386, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [9/36] Add pte accessors for the global bit, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [8/36] CPA: Do a simple self test at boot, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [4/36] CPA: Undo white space changes, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [1/36] Undo pat cpa patch, Andi Kleen, (Wed Jan 16, 6:14 pm)