Re: [PATCH 4 of 4] x86: mask NX from pte_pfn

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Hugh Dickins <hugh@...>

Cc: Jeremy Fitzhardinge <jeremy@...>, LKML <linux-kernel@...>, Andi Kleen <ak@...>, Glauber de Oliveira Costa <glommer@...>, Jan Beulich <jbeulich@...>

Subject: Re: [PATCH 4 of 4] x86: mask NX from pte_pfn

Date: Friday, January 18, 2008 - 10:01 am

* Hugh Dickins <hugh@veritas.com> wrote:

quoted text> > -	return pte_val(pte) >> PAGE_SHIFT;
> > +	return (pte_val(pte) >> PAGE_SHIFT) & ~_PAGE_NX;

quoted text> Shouldn't that be
> 
> 	return (pte_val(pte) & ~_PAGE_NX) >> PAGE_SHIFT;

ouch! Sharp eyes! Fixed it.

	Ingo
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Tue Jan 15, 6:35 pm)

Re: [PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Tue Jan 15, 7:28 pm)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 10:22 am)

Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 10:44 am)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 10:54 am)

Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 11:26 am)

Re: [PATCH 0 of 4] x86: some more patches, Jan Beulich, (Wed Jan 16, 11:42 am)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 11:47 am)

Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 1:40 pm)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 4:22 pm)

Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 4:59 pm)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 5:06 pm)

Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 5:35 pm)

Re: [PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Wed Jan 16, 1:05 pm)

Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 1:12 pm)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 12:06 pm)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 11:18 am)

Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Tue Jan 15, 8:44 pm)

Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 3:25 am)

[PATCH 1 of 4] x86: refactor mmu ops in paravirt.h, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)

[PATCH 3 of 4] x86: clean up pte_modify, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)

Re: [PATCH 3 of 4] x86: clean up pte_modify, Andi Kleen, (Tue Jan 15, 8:43 pm)

[PATCH 2 of 4] x86: fix warning, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)

[PATCH 4 of 4] x86: mask NX from pte_pfn, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)

Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Hugh Dickins, (Fri Jan 18, 9:52 am)

Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Jeremy Fitzhardinge, (Fri Jan 18, 11:55 am)

Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Ingo Molnar, (Fri Jan 18, 10:01 am)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Justin Piszcz	exception Emask 0x0 SAct 0x1 / SErr 0x0 action 0x2 frozen
Heiko Carstens	Re: -mm merge plans for 2.6.23 -- sys_fallocate
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
Radu Rendec	htb parallelism on multi-core platforms
openbsd-misc:

Colocation donated by:

Online users

Syndicate