login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
January
»
18
Re: [PATCH] update checkpatch.pl to version 0.13
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Benny Halevy <bhalevy@...>
To: Andy Whitcroft <apw@...>
Cc: Andrew Morton <akpm@...>, Randy Dunlap <rdunlap@...>, Joel Schopp <jschopp@...>, <linux-kernel@...>
Subject:
Re: [PATCH] update checkpatch.pl to version 0.13
Date: Friday, January 18, 2008 - 9:10 am
On Jan. 18, 2008, 13:37 +0200, Andy Whitcroft <apw@shadowen.org> wrote:
quoted text
> On Thu, Jan 17, 2008 at 11:19:23AM -0800, Andrew Morton wrote: >> On Thu, 17 Jan 2008 16:23:51 -0000 Andy Whitcroft <apw@shadowen.org> wrote: >> >>> This version brings a large number of fixes which have built up over >>> the Christmas period. Mostly these are fixes for false positives, both >>> through improvments to unary checks and possible type detection. It >>> also brings new checks for while location and CVS keywords. >> heh. Doctor, heal thyself. > > Heh, yeah I was feeling pressure to push out the update and forgot to > check it. Spanner. > > I have fixed the three lines which have random tabs on them. Its > something I do in vi which is adding them, one day I will figure out > what the heck it is I do.
autoindent set by any chance? try :set noai If you you like it better this way you can configure it in your vi{,m}rc Benny
quoted text
> > -apw > > --- > clean up some space violations in checkpatch.pl > > Seems that something I do in vi leaves lines with multiple tabs on > them lying about. Clean these up before edit things more. > > Signed-off-by: Andy Whitcroft <apw@shadowen.org> > --- > checkpatch.pl | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/checkpatch.pl b/checkpatch.pl > index 07ba401..a2b4c41 100755 > --- a/checkpatch.pl > +++ b/checkpatch.pl > @@ -341,7 +341,7 @@ sub sanitise_line { > my $clean = 'X' x length(); > $res =~ s@(#\s*(?:error|warning)\s+).*@$clean@; > } > - > + > return $res; > } > > @@ -947,7 +947,7 @@ sub process { > if ($realcnt) { > # Ignore goto labels. > if ($line =~ /$Ident:\*$/) { > - > + > # Ignore functions being called > } elsif ($line =~ /^.\s*$Ident\s*\(/) { > > @@ -1190,7 +1190,7 @@ sub process { > > # Ignore those directives where spaces _are_ permitted. > if ($name =~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/) { > - > + > # cpp #define statements have non-optional spaces, ie > # if there is a space between the name and the open > # parenthesis it is simply not a parameter group.
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] update checkpatch.pl to version 0.13
, Andy Whitcroft
, (Thu Jan 17, 12:23 pm)
Re: [PATCH] update checkpatch.pl to version 0.13
, Andrew Morton
, (Thu Jan 17, 3:19 pm)
Re: [PATCH] update checkpatch.pl to version 0.13
, Andy Whitcroft
, (Fri Jan 18, 7:37 am)
Re: [PATCH] update checkpatch.pl to version 0.13
, Benny Halevy
, (Fri Jan 18, 9:10 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Amit K. Arora
[RFC] Heads up on sys_fallocate()
Chuck Ebbert
Why do so many machines need "noapic"?
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Natalie Protasevich
[BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
428 guests
online.
Syndicate