Home » Mailing list archives » linux-kernel » 2008 » January » 18

Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: Michael Opdenacker <michael-lists@...>
Cc: Matt Mackall <mpm@...>, <linux-kernel@...>, <Linux-tiny@...>, Thomas Gleixner <tglx@...>
Subject: Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling
Date: Friday, January 18, 2008 - 8:29 am

* Ingo Molnar <mingo@elte.hu> wrote:


i've added your patch to x86.git - see below.

	Ingo

----------->
Subject: x86: fix unconditional arch/x86/kernel/pcspeaker.o compiling
From: Michael Opdenacker <michael-lists@free-electrons.com>

do not add the pcspkr platform device if pcspkr support is disabled.

Signed-off-by: Michael Opdenacker <michael@free-electrons.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/Makefile |    3 +++
 1 file changed, 3 insertions(+)

Index: linux-x86.q/arch/x86/kernel/Makefile
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/Makefile
+++ linux-x86.q/arch/x86/kernel/Makefile
@@ -68,7 +68,10 @@ obj-$(CONFIG_MGEODE_LX)		+= geode_32.o m
 
 obj-$(CONFIG_VMI)		+= vmi_32.o vmiclock_32.o
 obj-$(CONFIG_PARAVIRT)		+= paravirt.o paravirt_patch_$(BITS).o
+
+ifdef CONFIG_INPUT_PCSPKR
 obj-y				+= pcspeaker.o
+endif
 
 obj-$(CONFIG_SCx200)		+= scx200_32.o
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c c..., Michael Opdenacker, (Thu Jan 17, 11:43 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Thu Jan 17, 12:36 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Michael Opdenacker, (Thu Jan 17, 1:05 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Jan Engelhardt, (Thu Jan 17, 6:44 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Thu Jan 17, 1:13 pm)
Re: [PATCH] x86: fix unconditional , Michael Opdenacker, (Thu Jan 17, 6:15 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Ingo Molnar, (Fri Jan 18, 7:02 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Michael Opdenacker, (Fri Jan 18, 8:14 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Ingo Molnar, (Fri Jan 18, 8:25 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Ingo Molnar, (Fri Jan 18, 8:29 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Michael Opdenacker, (Fri Jan 18, 9:03 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Fri Jan 18, 9:50 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Michael Opdenacker, (Fri Jan 18, 12:29 pm)
Re: [PATCH] x86: , Rob Landley, (Sun Jan 20, 8:25 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Fri Jan 18, 1:10 pm)
Re: [PATCH] x86: , Michael Opdenacker, (Wed Jan 23, 6:30 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Dmitri Vorobiev, (Thu Jan 24, 4:12 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Ralf Baechle, (Fri Jan 25, 12:09 pm)
Re: [PATCH] x86: fix?unconditional?arch/x86/kernel/pcspeaker..., Adrian Bunk, (Thu Jan 24, 1:09 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Michael Opdenacker, (Mon Jan 21, 11:31 am)
Re: [PATCH] x86: , Rob Landley, (Sun Jan 20, 12:59 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Sun Jan 20, 12:44 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Ingo Molnar, (Fri Jan 18, 5:09 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Fri Jan 18, 6:39 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Ingo Molnar, (Tue Jan 22, 10:39 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Tue Jan 22, 12:37 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Sam Ravnborg, (Tue Jan 22, 2:58 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Tue Jan 22, 3:17 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Ingo Molnar, (Fri Jan 18, 9:57 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Matt Mackall, (Fri Jan 18, 10:04 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Taral, (Thu Jan 17, 11:16 pm)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Michael Opdenacker, (Fri Jan 18, 4:22 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Taral, (Sat Jan 19, 3:21 am)
Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker..., Michael Opdenacker, (Thu Jan 17, 2:32 pm)