Re: [patch 0/4] x86: PAT followup - Incremental changes and bug fixes

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andreas Herrmann3 <andreas.herrmann3@...>
Cc: Venki Pallipadi <venkatesh.pallipadi@...>, <ak@...>, <ebiederm@...>, <rdreier@...>, <torvalds@...>, <gregkh@...>, <airlied@...>, <davej@...>, <tglx@...>, <hpa@...>, <akpm@...>, <arjan@...>, <jesse.barnes@...>, <davem@...>, <linux-kernel@...>, <suresh.b.siddha@...>
Date: Thursday, January 17, 2008 - 4:36 pm

* Andreas Herrmann3 <andreas.herrmann3@amd.com> wrote:


hm, is the problem that the two devices share the same physical page, 
and thus get an overlapping area?

as an intermediate fix, how about following the attribute of the already 
existing mapping, instead of rejecting the ioremap due to the conflict? 
I.e. something like below?

	Ingo

---
 arch/x86/mm/pat.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Index: linux-x86.q/arch/x86/mm/pat.c
===================================================================
--- linux-x86.q.orig/arch/x86/mm/pat.c
+++ linux-x86.q/arch/x86/mm/pat.c
@@ -174,7 +174,12 @@ int reserve_mattr(u64 start, u64 end, un
 					current->comm, current->pid,
 					start, end,
 					cattr_name(attr), cattr_name(ml->attr));
-				err = -EBUSY;
+				/*
+				 * Force the already existing attribute:
+				 */
+				ma->attr = ml->attr;
+				if (*fattr)
+					*fatt = ml->attr;
 				break;
 			}
 		} else if (ml->start >= end) {
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 3:12 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Ingo Molnar, (Thu Jan 17, 4:36 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 5:03 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 5:42 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:26 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 7:06 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:16 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Eric W. Biederman, (Thu Jan 24, 4:22 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:06 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:52 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Fri Jan 18, 12:10 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Fri Jan 18, 1:13 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 7:24 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Thu Jan 17, 7:42 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 3:54 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Wed Jan 16, 6:14 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Wed Jan 16, 3:05 pm)