Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: "Daniel Sp蚣g" <daniel.spang@...>
Cc: <kosaki.motohiro@...>, Rik van Riel <riel@...>, <linux-mm@...>, <linux-kernel@...>, Marcelo Tosatti <marcelo@...>, Andrew Morton <akpm@...>
Date: Wednesday, January 16, 2008 - 11:26 pm

Hi Daniel


Unfortunately, I can't reproduce it.

my machine
	CPU:    Pentium4 2.8GHz with HT
	memory: 512M


1. I doubt ZONE_DMA, please shipment ignore zone_dma patch(below).
2. Could you please send your .config and /etc/sysctl.conf?
   I hope more reproduce challenge.

thanks.

- kosaki




Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

---
 include/linux/mem_notify.h |    3 +++
 mm/page_alloc.c            |    6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

Index: linux-2.6.24-rc6-mm1-memnotify/include/linux/mem_notify.h
===================================================================
--- linux-2.6.24-rc6-mm1-memnotify.orig/include/linux/mem_notify.h
 2008-01-16 21:31:09.000000000 +0900
+++ linux-2.6.24-rc6-mm1-memnotify/include/linux/mem_notify.h
2008-01-16 21:34:24.000000000 +0900
@@ -22,6 +22,9 @@ static inline void memory_pressure_notif
        unsigned long target;
        unsigned long pages_high, pages_free, pages_reserve;

+       if (unlikely(zone->mem_notify_status == -1))
+               return;
+
        if (pressure) {
                target = atomic_long_read(&last_mem_notify) + MEM_NOTIFY_FREQ;
                if (likely(time_before(jiffies, target)))
Index: linux-2.6.24-rc6-mm1-memnotify/mm/page_alloc.c
===================================================================
--- linux-2.6.24-rc6-mm1-memnotify.orig/mm/page_alloc.c 2008-01-13
19:50:27.000000000 +0900
+++ linux-2.6.24-rc6-mm1-memnotify/mm/page_alloc.c      2008-01-16
21:41:58.000000000 +0900
@@ -3467,7 +3467,11 @@ static void __meminit free_area_init_cor
                zone->zone_pgdat = pgdat;

                zone->prev_priority = DEF_PRIORITY;
-               zone->mem_notify_status = 0;
+
+               if (zone->present_pages < (pgdat->node_present_pages / 10))
+                       zone->mem_notify_status = -1;
+               else
+                       zone->mem_notify_status = 0;

                zone_pcp_init(zone);
                INIT_LIST_HEAD(&zone->active_list);



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 0/5] mem notifications v4, KOSAKI Motohiro, (Mon Jan 14, 8:52 pm)
[RFC][PATCH 5/5] /proc/zoneinfo enhancement, KOSAKI Motohiro, (Mon Jan 14, 9:03 pm)
Re: [RFC][PATCH 5/5] /proc/zoneinfo enhancement, Alan Cox, (Tue Jan 15, 6:44 am)
Re: [RFC][PATCH 5/5] /proc/zoneinfo enhancement, KOSAKI Motohiro, (Tue Jan 15, 6:49 am)
[RFC][PATCH 4/5] memory_pressure_notify() caller, KOSAKI Motohiro, (Mon Jan 14, 9:02 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, Daniel Spång, (Tue Jan 15, 6:55 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, Rik van Riel, (Tue Jan 15, 6:59 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, Daniel Spång, (Tue Jan 15, 7:39 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, KOSAKI Motohiro, (Tue Jan 15, 9:48 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, Daniel Spång, (Wed Jan 16, 7:03 am)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, KOSAKI Motohiro, (Wed Jan 16, 11:26 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, Daniel Spång, (Fri Jan 18, 6:24 am)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, KOSAKI Motohiro, (Fri Jan 18, 6:30 am)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, KAMEZAWA Hiroyuki, (Mon Jan 14, 10:06 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, KOSAKI Motohiro, (Mon Jan 14, 10:37 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, KAMEZAWA Hiroyuki, (Mon Jan 14, 11:00 pm)
Re: [RFC][PATCH 4/5] memory_pressure_notify() caller, KOSAKI Motohiro, (Mon Jan 14, 11:08 pm)
[RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Mon Jan 14, 9:01 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Pavel Machek, (Tue Jan 15, 6:16 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Tue Jan 15, 9:57 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Marcelo Tosatti, (Wed Jan 16, 12:13 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Pavel Machek, (Wed Jan 16, 7:42 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Daniel Spång, (Wed Jan 16, 7:51 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Wed Jan 16, 11:04 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Alan Cox, (Tue Jan 15, 6:46 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Tue Jan 15, 6:59 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Alan Cox, (Tue Jan 15, 7:20 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Marcelo Tosatti, (Tue Jan 15, 8:05 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Alan Cox, (Tue Jan 15, 9:42 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Tue Jan 15, 7:48 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Alan Cox, (Tue Jan 15, 9:42 am)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Tue Jan 15, 10:43 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KAMEZAWA Hiroyuki, (Mon Jan 14, 10:10 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Mon Jan 14, 10:20 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Rik van Riel, (Mon Jan 14, 10:56 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, Randy Dunlap, (Mon Jan 14, 9:08 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Mon Jan 14, 9:20 pm)
Re: [RFC][PATCH 3/5] add /dev/mem_notify device, KOSAKI Motohiro, (Mon Jan 14, 9:24 pm)
[RFC][PATCH 2/5] introduce wake_up_locked_nr() new API, KOSAKI Motohiro, (Mon Jan 14, 9:00 pm)
[RFC][PATCH 1/5] introduce poll_wait_exclusive() new API , KOSAKI Motohiro, (Mon Jan 14, 8:59 pm)