[PATCH 5 of 8] x86/paravirt: common implementation for pmd value ops

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: LKML <linux-kernel@...>, Andi Kleen <ak@...>, Glauber de Oliveira Costa <glommer@...>, Jan Beulich <jbeulich@...>
Date: Wednesday, January 16, 2008 - 7:27 pm

Remove duplicate __pmd/pmd_val functions.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
---
 include/asm-x86/paravirt.h |   33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/include/asm-x86/paravirt.h b/include/asm-x86/paravirt.h
--- a/include/asm-x86/paravirt.h
+++ b/include/asm-x86/paravirt.h
@@ -978,18 +978,37 @@ static inline pgdval_t pgd_val(pgd_t pgd
 	return ret;
 }
 
-#ifdef CONFIG_X86_PAE
-static inline pmd_t __pmd(unsigned long long val)
+#if PAGETABLE_LEVELS >= 3
+static inline pmd_t __pmd(pmdval_t val)
 {
-	return (pmd_t) { PVOP_CALL2(unsigned long long, pv_mmu_ops.make_pmd,
-				    val, val >> 32) };
+	pmdval_t ret;
+
+	if (sizeof(pmdval_t) > sizeof(long))
+		ret = PVOP_CALL2(pmdval_t, pv_mmu_ops.make_pmd,
+				 val, (u64)val >> 32);
+	else
+		ret = PVOP_CALL1(pmdval_t, pv_mmu_ops.make_pmd,
+				 val);
+
+	return (pmd_t) { ret };
 }
 
-static inline unsigned long long pmd_val(pmd_t x)
+static inline pmdval_t pmd_val(pmd_t pmd)
 {
-	return PVOP_CALL2(unsigned long long, pv_mmu_ops.pmd_val,
-			  x.pmd, x.pmd >> 32);
+	pmdval_t ret;
+
+	if (sizeof(pmdval_t) > sizeof(long))
+		ret =  PVOP_CALL2(pmdval_t, pv_mmu_ops.pmd_val,
+				  pmd.pmd, (u64)pmd.pmd >> 32);
+	else
+		ret =  PVOP_CALL1(pmdval_t, pv_mmu_ops.pmd_val,
+				  pmd.pmd);
+
+	return ret;
 }
+#endif	/* PAGETABLE_LEVELS >= 3 */
+
+#ifdef CONFIG_X86_PAE
 
 static inline void set_pte(pte_t *ptep, pte_t pteval)
 {


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0 of 8] x86: refactored paravirt mmu_ops, Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
Re: [PATCH 0 of 8] x86: refactored paravirt mmu_ops, Ingo Molnar, (Thu Jan 17, 3:01 am)
[PATCH 3 of 8] x86/paravirt: common implementation for pte v..., Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
[PATCH 5 of 8] x86/paravirt: common implementation for pmd v..., Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
[PATCH 8 of 8] x86/paravirt: make set_pud operation common, Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
[PATCH 7 of 8] x86/paravirt: make set_pmd operation common, Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
[PATCH 6 of 8] x86/paravirt: make set_pte operations common, Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
[PATCH 4 of 8] x86/paravirt: common implementation for pgd v..., Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
[PATCH 2 of 8] x86/paravirt: rearrange common mmu_ops, Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)
[PATCH 1 of 8] add native_pud_val and _pmd_val for 2 and 3 l..., Jeremy Fitzhardinge, (Wed Jan 16, 7:27 pm)