Home » Mailing list archives » linux-kernel » 2008 » January » 16

[PATCH] [28/36] CPA: Remove unnecessary masking of address

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <ak@...>
To: <linux-kernel@...>, <mingo@...>, <tglx@...>, <jbeulich@...>, <venkatesh.pallipadi@...>
Subject: [PATCH] [28/36] CPA: Remove unnecessary masking of address
Date: Wednesday, January 16, 2008 - 6:15 pm

virt_to_page does not care about the bits below the page granuality.
So don't mask them.

Signed-off-by: Andi Kleen <ak@suse.de>
Acked-by: Jan Beulich <jbeulich@novell.com>

---
 arch/x86/mm/pageattr_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/arch/x86/mm/pageattr_64.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr_64.c
+++ linux/arch/x86/mm/pageattr_64.c
@@ -204,7 +204,7 @@ __change_page_attr(unsigned long address
 
 	kpte = lookup_address(address, &level);
 	if (!kpte) return 0;
-	kpte_page = virt_to_page(((unsigned long)kpte) & PAGE_MASK);
+	kpte_page = virt_to_page(kpte);
 	BUG_ON(PageCompound(kpte_page));
 	BUG_ON(PageLRU(kpte_page));
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/36] Great change_page_attr patch series v3, Andi Kleen, (Wed Jan 16, 6:14 pm)
Re: [PATCH] [0/36] Great change_page_attr patch series v3, Ingo Molnar, (Fri Jan 18, 5:56 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Fri Jan 18, 11:33 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Fri Jan 18, 11:56 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Fri Jan 18, 12:01 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Fri Jan 18, 12:07 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Fri Jan 18, 12:16 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Fri Jan 18, 12:21 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Fri Jan 18, 12:34 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Fri Jan 18, 12:48 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Fri Jan 18, 1:19 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Mon Jan 21, 12:40 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Mon Jan 21, 1:13 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Thomas Gleixner, (Tue Jan 22, 9:12 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Tue Jan 22, 9:23 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Thomas Gleixner, (Tue Jan 22, 10:06 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Tue Jan 22, 10:21 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Thomas Gleixner, (Tue Jan 22, 8:35 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Wed Jan 23, 4:09 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Tue Jan 22, 8:00 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Wed Jan 23, 5:05 am)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Andi Kleen, (Fri Jan 18, 12:05 pm)
Re: CPA boot crash (was: [PATCH] [0/36] Great change_page_at..., Ingo Molnar, (Fri Jan 18, 11:38 am)
[PATCH] [35/36] Remove set_kernel_exec, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [36/36] Clean up pte_exec, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [34/36] CPA: Add a BUG_ON checking for someone setti..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [32/36] CPA: Change comments of external interfaces ..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [33/36] CPA: Make kernel_text test match boot mappin..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [31/36] CPA: Fix reference counting when changing al..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [30/36] CPA: Always do full TLB flush when splitting..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [29/36] CPA: Only unmap kernel init pages in text ma..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [28/36] CPA: Remove unnecessary masking of address, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [27/36] CPA: Only queue actually unused page table p..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [25/36] CPA: Fix inaccurate comments in 64bit change..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [26/36] CPA: Dump pagetable when inconsistency is de..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [24/36] CPA: Limit cache flushing to pages that real..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [23/36] CPA: Make change_page_attr() more robust aga..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [22/36] CPA: Reorder TLB / cache flushes to follow I..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [21/36] CPA: Use wbinvd() macro instead of inline as..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [20/36] CPA: Don't flush the caches when the CPU sup..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [19/36] CPA: Use page granuality TLB flushing in cha..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [18/36] CPA: Use macros to modify the PG_arch_1 page..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [17/36] CPA: CLFLUSH support in change_page_attr(), Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [16/36] CPA: Change 32bit back to init_mm semaphore ..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [15/36] CPA: Change kernel_map_pages to not use c_p_..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [14/36] CPA: Add simple self test at boot, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [13/36] CPA: Return the page table level in lookup_a..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [12/36] Extract page table dumping code from i386 fa..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [11/36] Don't drop NX bit in pte modifier functions ..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [10/36] Add pte_pgprot on i386, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [9/36] Add pte accessors for the global bit, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [8/36] CPA: Do a simple self test at boot, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [7/36] Shrink __PAGE_KERNEL/__PAGE_KERNEL_EXEC on no..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [6/36] CPA Handle 4K split pages at boot on 64bit, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [5/36] CPA: Implement change_page_attr_addr entry po..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [4/36] CPA: Undo white space changes, Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [3/36] Undo pageattr_64 parts of 4157e20af49a04d75a8..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [2/36] Undo pageattr_32 portions of 11c9734cbcf4c586..., Andi Kleen, (Wed Jan 16, 6:15 pm)
[PATCH] [1/36] Undo pat cpa patch, Andi Kleen, (Wed Jan 16, 6:14 pm)