Re: [patch 0/4] x86: PAT followup - Incremental changes and bug fixes

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andreas Herrmann <andreas.herrmann3@...>
Cc: <venkatesh.pallipadi@...>, <ak@...>, <ebiederm@...>, <rdreier@...>, <torvalds@...>, <gregkh@...>, <airlied@...>, <davej@...>, <mingo@...>, <tglx@...>, <hpa@...>, <akpm@...>, <arjan@...>, <jesse.barnes@...>, <davem@...>, <linux-kernel@...>, <suresh.b.siddha@...>
Date: Wednesday, January 16, 2008 - 4:33 pm

On Wed, Jan 16, 2008 at 07:57:48PM +0100, Andreas Herrmann wrote:
This does not look to be the problem here. We just mapped some new low
address due to possibly a different code path. But, seems to have worked fine.


This ioremap failing seems to be the real problem. This can be due to
new tracking of ioremaps introduced by PAT patches. We do not allow
conflicting ioremaps to same region. Probably that is happening
in both Sound and sata initialization which results in driver init failing.

Can you please try the debug patch below over latest x86/mm and boot kernel with
debug boot option and send us the dmesg from the failure. That will give us
better info about ioremaps.

Thanks,
Venki


Index: linux-2.6.git/arch/x86/mm/ioremap_64.c
===================================================================
--- linux-2.6.git.orig/arch/x86/mm/ioremap_64.c	2008-01-16 03:38:32.000000000 -0800
+++ linux-2.6.git/arch/x86/mm/ioremap_64.c	2008-01-16 05:16:28.000000000 -0800
@@ -150,6 +150,8 @@
 
 void __iomem *ioremap_nocache (unsigned long phys_addr, unsigned long size)
 {
+	printk(KERN_DEBUG "ioremap_nocache: addr %lx, size %lx\n",
+	       phys_addr, size);
 	return __ioremap(phys_addr, size, _PAGE_UC);
 }
 EXPORT_SYMBOL(ioremap_nocache);
Index: linux-2.6.git/include/asm-x86/io_64.h
===================================================================
--- linux-2.6.git.orig/include/asm-x86/io_64.h	2008-01-16 03:38:32.000000000 -0800
+++ linux-2.6.git/include/asm-x86/io_64.h	2008-01-16 05:16:57.000000000 -0800
@@ -154,6 +154,8 @@
 
 static inline void __iomem * ioremap (unsigned long offset, unsigned long size)
 {
+	printk(KERN_DEBUG "ioremap: addr %lx, size %lx\n",
+	       offset, size);
 	return __ioremap(offset, size, 0);
 }
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Venki Pallipadi, (Wed Jan 16, 4:33 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 3:12 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 5:03 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 5:42 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:26 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 7:06 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:16 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Eric W. Biederman, (Thu Jan 24, 4:22 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:06 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 6:52 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Fri Jan 18, 12:10 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Fri Jan 18, 1:13 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 7:24 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Thu Jan 17, 7:42 pm)
Re: [patch 0/4] x86: PAT followup - Incremental changes and ..., Andreas Herrmann3, (Thu Jan 17, 3:54 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Wed Jan 16, 6:14 pm)
RE: [patch 0/4] x86: PAT followup - Incremental changes and ..., Pallipadi, Venkatesh, (Wed Jan 16, 3:05 pm)