[PATCH 3 of 4] x86: clean up pte_modify

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: LKML <linux-kernel@...>, Andi Kleen <ak@...>, Glauber de Oliveira Costa <glommer@...>, Jan Beulich <jbeulich@...>
Date: Tuesday, January 15, 2008 - 6:17 pm

pte_modify() got mushed in an apparent mismerge.  Fix it up.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>

---
 include/asm-x86/pgtable.h |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/asm-x86/pgtable.h b/include/asm-x86/pgtable.h
--- a/include/asm-x86/pgtable.h
+++ b/include/asm-x86/pgtable.h
@@ -176,14 +176,11 @@ static inline pte_t pte_modify(pte_t pte
 {
 	pteval_t val = pte_val(pte);
 
-	val &= _PAGE_CHG_MASK;
-	val |= pgprot_val(newprot);
-
 	/*
 	 * Chop off the NX bit (if present), and add the NX portion of
 	 * the newprot (if present):
 	 */
-	val &= ~_PAGE_NX;
+	val &= _PAGE_CHG_MASK & ~_PAGE_NX;
 	val |= pgprot_val(newprot) & __supported_pte_mask;
 
 	return __pte(val);


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Tue Jan 15, 6:35 pm)
Re: [PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Tue Jan 15, 7:28 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 10:22 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 10:44 am)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 10:54 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 11:26 am)
Re: [PATCH 0 of 4] x86: some more patches, Jan Beulich, (Wed Jan 16, 11:42 am)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 11:47 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 1:40 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 4:22 pm)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 4:59 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 5:06 pm)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 5:35 pm)
Re: [PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Wed Jan 16, 1:05 pm)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 1:12 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 12:06 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 11:18 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Tue Jan 15, 8:44 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 3:25 am)
[PATCH 1 of 4] x86: refactor mmu ops in paravirt.h, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
[PATCH 3 of 4] x86: clean up pte_modify, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
Re: [PATCH 3 of 4] x86: clean up pte_modify, Andi Kleen, (Tue Jan 15, 8:43 pm)
[PATCH 2 of 4] x86: fix warning, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
[PATCH 4 of 4] x86: mask NX from pte_pfn, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Hugh Dickins, (Fri Jan 18, 9:52 am)
Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Jeremy Fitzhardinge, (Fri Jan 18, 11:55 am)
Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Ingo Molnar, (Fri Jan 18, 10:01 am)