[PATCH 4 of 4] x86: mask NX from pte_pfn

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: LKML <linux-kernel@...>, Andi Kleen <ak@...>, Glauber de Oliveira Costa <glommer@...>, Jan Beulich <jbeulich@...>
Date: Tuesday, January 15, 2008 - 6:17 pm

In 32-bit PAE, mask NX from pte_pfn, since it isn't part of the PFN.
This code is due for unification anyway, but this fixes a latent bug.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>

---
 include/asm-x86/pgtable-3level.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-x86/pgtable-3level.h b/include/asm-x86/pgtable-3level.h
--- a/include/asm-x86/pgtable-3level.h
+++ b/include/asm-x86/pgtable-3level.h
@@ -139,7 +139,7 @@ static inline int pte_none(pte_t pte)
 
 static inline unsigned long pte_pfn(pte_t pte)
 {
-	return pte_val(pte) >> PAGE_SHIFT;
+	return (pte_val(pte) >> PAGE_SHIFT) & ~_PAGE_NX;
 }
 
 /*


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Tue Jan 15, 6:35 pm)
Re: [PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Tue Jan 15, 7:28 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 10:22 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 10:44 am)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 10:54 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 11:26 am)
Re: [PATCH 0 of 4] x86: some more patches, Jan Beulich, (Wed Jan 16, 11:42 am)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 11:47 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 1:40 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 4:22 pm)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 4:59 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 5:06 pm)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 5:35 pm)
Re: [PATCH 0 of 4] x86: some more patches, Jeremy Fitzhardinge, (Wed Jan 16, 1:05 pm)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Wed Jan 16, 1:12 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 12:06 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 11:18 am)
Re: [PATCH 0 of 4] x86: some more patches, Andi Kleen, (Tue Jan 15, 8:44 pm)
Re: [PATCH 0 of 4] x86: some more patches, Ingo Molnar, (Wed Jan 16, 3:25 am)
[PATCH 1 of 4] x86: refactor mmu ops in paravirt.h, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
[PATCH 3 of 4] x86: clean up pte_modify, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
Re: [PATCH 3 of 4] x86: clean up pte_modify, Andi Kleen, (Tue Jan 15, 8:43 pm)
[PATCH 2 of 4] x86: fix warning, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
[PATCH 4 of 4] x86: mask NX from pte_pfn, Jeremy Fitzhardinge, (Tue Jan 15, 6:17 pm)
Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Hugh Dickins, (Fri Jan 18, 9:52 am)
Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Jeremy Fitzhardinge, (Fri Jan 18, 11:55 am)
Re: [PATCH 4 of 4] x86: mask NX from pte_pfn, Ingo Molnar, (Fri Jan 18, 10:01 am)