login
Header Space

 
 

Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andi Kleen <andi@...>
Cc: Ingo Molnar <mingo@...>, Adrian Bunk <bunk@...>, <rjw@...>, <pavel@...>, <linux-kernel@...>
Date: Tuesday, January 15, 2008 - 2:21 pm

> > 
I have fixed a lot of these warnings.
And when I look closer at them they are explainable.

The warnings are today very dependent on the configuration
and the inlining that gcc uses.
With default options to gcc my .config produces ~65 warnings
but with -fno-unit-a-time I get 112 warnings.
Solely due to less inlining done by gcc.

So there are two sources for the 'randomization':
a) The actual config
b) The sometimes agressive inlining

a) will be addressed by having separate sections for each
__init* type that is at link time combined where it belongs.

b) is addressed by a Kernel Hacking option which
   1) uses -fno-unit-at-a-time to get less gcc inlining
   2) maybe make all __*init function no-inline
   3) maybe disable inlining globally

Are there any better way to tell gcc no to inline so agressively?

	Sam
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH x86] [0/16] Various i386/x86-64 changes, Andi Kleen, (Thu Jan 3, 11:42 am)
[PATCH x86] [16/16] Mark memory_setup __init, Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [16/16] Mark memory_setup __init, Ingo Molnar, (Fri Jan 4, 5:25 am)
Re: [PATCH x86] [16/16] Mark memory_setup __init, Ingo Molnar, (Fri Jan 4, 5:53 am)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Rafael J. Wysocki, (Thu Jan 10, 1:14 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Rafael J. Wysocki, (Thu Jan 10, 1:17 pm)
[PATCH] x86: Change unnecessary dependencies on CONFIG_PM, Rafael J. Wysocki, (Fri Jan 11, 7:06 pm)
Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM wit..., Sam Ravnborg, (Tue Jan 15, 2:21 pm)
[PATCH x86] [8/16] Make lockdep_init __init, Andi Kleen, (Thu Jan 3, 11:42 am)
Re: [PATCH x86] [8/16] Make lockdep_init __init, Ingo Molnar, (Fri Jan 4, 5:06 am)
speck-geostationary