login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
January
»
15
Re: [PATCH] x86_64: checking aperture report for node instead of cpu
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Ingo Molnar <mingo@...>
To: Yinghai Lu <Yinghai.Lu@...>
Cc: Andi Kleen <ak@...>, Andrew Morton <akpm@...>, Thomas Gleixner <tglx@...>, Christoph Lameter <clameter@...>, <ebiederm@...>, LKML <linux-kernel@...>
Subject:
Re: [PATCH] x86_64: checking aperture report for node instead of cpu
Date: Tuesday, January 15, 2008 - 9:22 am
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
quoted text
> - printk(KERN_INFO "CPU %d: aperture @ %Lx size %u MB\n", > - num-24, aper_base, aper_size>>20); > + printk(KERN_INFO "Node %d: aperture @ %Lx size %u MB\n", > + node++, aper_base, aper_size >> 20);
please dont put side-effects into printks. (put the node++ iteration out into a separate line) Your patch looks fine otherwise. Ingo --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] x86-64: disable the GART early
, Yinghai Lu
, (Thu Jan 10, 11:14 pm)
[PATCH] x86-64: disable the GART early v2
, Yinghai Lu
, (Fri Jan 11, 3:54 am)
Re: [PATCH] x86-64: disable the GART early v2
, Ingo Molnar
, (Fri Jan 11, 4:14 am)
Re: [PATCH] x86-64: disable the GART early v2
, Yinghai Lu
, (Sat Jan 12, 6:07 am)
Re: [PATCH] x86-64: disable the GART early v2
, Ingo Molnar
, (Mon Jan 14, 4:35 am)
[PATCH] x86_64: checking aperture report for node instead of...
, Yinghai Lu
, (Mon Jan 14, 9:39 pm)
Re: [PATCH] x86_64: checking aperture report for node instea...
, Ingo Molnar
, (Tue Jan 15, 9:22 am)
[PATCH] x86_64: checking aperture report for node instead
, Yinghai Lu
, (Tue Jan 15, 2:31 pm)
Re: [PATCH] x86_64: checking aperture report for node instea...
, Ingo Molnar
, (Fri Jan 18, 9:02 am)
[PATCH] x86-64: fix e820 for GART or disable the GART early
, Yinghai Lu
, (Fri Jan 11, 5:38 pm)
Re: [PATCH] x86-64: disable the GART early v2
, Yinghai Lu
, (Fri Jan 11, 4:34 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
monstr
[PATCH 27/56] microblaze_v2: support for a.out
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Rafael J. Wysocki
[Bug #10493] mips BCM47XX compile error
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller
[GIT]: Networking
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
11 users
and
960 guests
online.
Online users
seofirmyhcym
articlemarketi
zeekec
strcmp
freebabydiaper
wordpressdirec
deskmatzhgw
britaxyfp
truthaboutabsi
dataentryemplo
bacterialyeast
Syndicate