Home » Mailing list archives » linux-kernel » 2008 » January » 15

Re: [PATCH] [12/31] CPA: CLFLUSH support in change_page_attr()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jan Beulich
Subject: Re: [PATCH] [12/31] CPA: CLFLUSH support in change_page_attr()
Date: Tuesday, January 15, 2008 - 1:40 am

>-	/* clflush is still broken. Disable for now. */

This if() looks redundant (could also be avoided in the 32-bit variant, but
isn't redundant there at present). Also, is there no
wbinvd() on 64bit?

Jan

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/31] Great change_page_attr patch series v2, Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [2/31] CPA: Do a simple self test at boot, Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [3/31] Add pte accessors for the global bit, Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [4/31] Add pte_pgprot on i386, Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [5/31] Don't drop NX bit in pte modifier functions ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [6/31] CPA: Undo white space changes, Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [7/31] Extract page table dumping code from i386 f ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [8/31] CPA: Return the page table level in lookup_ ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [9/31] CPA: Add simple self test at boot, Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [10/31] CPA: Change kernel_map_pages to not use c_ ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [11/31] CPA: Change 32bit back to init_mm semaphor ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [12/31] CPA: CLFLUSH support in change_page_attr(), Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 pa ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [14/31] CPA: Use page granuality TLB flushing in c ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [15/31] CPA: Don't flush the caches when the CPU s ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [17/31] CPA: Reorder TLB / cache flushes to follow ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [18/31] CPA: Make change_page_attr() more robust a ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [19/31] CPA: Limit cache flushing to pages that re ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [20/31] CPA: Fix inaccurate comments in 64bit chan ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [21/31] CPA: Dump pagetable when inconsistency is ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [22/31] CPA: Only queue actually unused page table ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [24/31] CPA: Only unmap kernel init pages in text ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [25/31] CPA: Always do full TLB flush when splitti ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [26/31] CPA: Fix reference counting when changing ..., Andi Kleen, (Mon Jan 14, 3:16 pm)
[PATCH] [27/31] CPA: Change comments of external interface ..., Andi Kleen, (Mon Jan 14, 3:17 pm)
[PATCH] [28/31] CPA: Make kernel_text test match boot mapp ..., Andi Kleen, (Mon Jan 14, 3:17 pm)
[PATCH] [29/31] CPA: Add a BUG_ON checking for someone set ..., Andi Kleen, (Mon Jan 14, 3:17 pm)
[PATCH] [30/31] Remove set_kernel_exec, Andi Kleen, (Mon Jan 14, 3:17 pm)
[PATCH] [31/31] Clean up pte_exec, Andi Kleen, (Mon Jan 14, 3:17 pm)
Re: [PATCH] [27/31] CPA: Change comments of external inter ..., Andi Kleen, (Mon Jan 14, 5:49 pm)
Re: [PATCH] [12/31] CPA: CLFLUSH support in change_page_attr(), Jan Beulich, (Tue Jan 15, 1:40 am)
Re: [PATCH] [19/31] CPA: Limit cache flushing to pages tha ..., Jan Beulich, (Tue Jan 15, 1:46 am)
Re: [PATCH] [2/31] CPA: Do a simple self test at boot, Harvey Harrison, (Tue Jan 15, 1:47 am)
Re: [PATCH] [26/31] CPA: Fix reference counting when chang ..., Jan Beulich, (Tue Jan 15, 2:05 am)
Re: [PATCH] [0/31] Great change_page_attr patch series v2, Jan Beulich, (Tue Jan 15, 2:11 am)
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_ ..., Harvey Harrison, (Tue Jan 15, 2:29 am)
Re: [PATCH] [12/31] CPA: CLFLUSH support in change_page_attr(), Andi Kleen, (Tue Jan 15, 2:57 am)
Re: [PATCH] [7/31] Extract page table dumping code from i3 ..., Andi Kleen, (Tue Jan 15, 3:00 am)
Re: [PATCH] [26/31] CPA: Fix reference counting when chang ..., Andi Kleen, (Tue Jan 15, 3:04 am)
Re: [PATCH] [7/31] Extract page table dumping code from i3 ..., Harvey Harrison, (Tue Jan 15, 3:05 am)
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_ ..., Andi Kleen, (Tue Jan 15, 3:06 am)
Re: [PATCH] [2/31] CPA: Do a simple self test at boot, Harvey Harrison, (Tue Jan 15, 3:07 am)
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_ ..., Harvey Harrison, (Tue Jan 15, 3:15 am)
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_ ..., Andi Kleen, (Tue Jan 15, 3:25 am)
Re: [PATCH] [9/31] CPA: Add simple self test at boot, Harvey Harrison, (Tue Jan 15, 3:37 am)
Re: [PATCH] [0/31] Great change_page_attr patch series v2, Jan Beulich, (Tue Jan 15, 4:55 am)
Re: [PATCH] [26/31] CPA: Fix reference counting when chang ..., Jan Beulich, (Tue Jan 15, 5:00 am)
Re: [PATCH] [0/31] Great change_page_attr patch series v2, Andi Kleen, (Tue Jan 15, 5:43 am)
Re: [PATCH] [4/31] Add pte_pgprot on i386, Johannes Weiner, (Tue Jan 15, 6:00 am)