Home » Mailing list archives » linux-kernel » 2008 » January » 14

[PATCH] Change a WARN message in checkpatch

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paolo Ciarrocchi <paolo.ciarrocchi@...>
To: <apw@...>
Cc: Linux Kernel <linux-kernel@...>
Subject: [PATCH] Change a WARN message in checkpatch
Date: Monday, January 14, 2008 - 6:29 pm

Hi Andy,
When I started using checkpatch I was confused by the following WARN message:

	no space between function name and open parenthesis

I thought the problem was that a space was missing while the truth is the opposite.

How about the following patch?


--- checkpatch.pl.old	2008-01-04 13:37:51.000000000 +0100
+++ checkpatch.pl	2008-01-04 13:37:24.000000000 +0100
@@ -1117,7 +1117,7 @@
 		while ($line =~ /($Ident)\s+\(/g) {
 			if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ &&
 		            $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
-				WARN("no space between function name and open parenthesis '('\n" . $herecurr);
+				WARN("don't put a space between function name and open parenthesis '('\n" . $herecurr);
 			}
 		}
 # Check operator spacing.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Change a WARN message in checkpatch, Paolo Ciarrocchi, (Mon Jan 14, 6:29 pm)
Re: [PATCH] Change a WARN message in checkpatch, Andy Whitcroft, (Mon Jan 28, 10:56 am)
Re: [PATCH] Change a WARN message in checkpatch, Paolo Ciarrocchi, (Mon Jan 28, 11:13 am)
Re: [PATCH] Change a WARN message in checkpatch, Paolo Ciarrocchi, (Sat Feb 23, 9:38 am)
Re: [PATCH] Change a WARN message in checkpatch, Benny Halevy, (Sun Feb 24, 11:18 am)
Re: [PATCH] Change a WARN message in checkpatch, Paolo Ciarrocchi, (Sun Feb 24, 2:14 pm)
Re: [PATCH] Change a WARN message in checkpatch, Andy Whitcroft, (Sun Feb 24, 11:29 pm)
Re: [PATCH] Change a WARN message in checkpatch, Paolo Ciarrocchi, (Mon Feb 25, 2:51 am)
Re: [PATCH] Change a WARN message in checkpatch, Andy Whitcroft, (Mon Feb 25, 6:53 am)
Re: [PATCH] Change a WARN message in checkpatch, Benny Halevy, (Mon Feb 25, 1:47 am)