Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost Tracing

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mathieu Desnoyers <mathieu.desnoyers@...>
Cc: Pavel Machek <pavel@...>, Ingo Molnar <mingo@...>, Frank Ch. Eigler <fche@...>, K. Prasad <prasad@...>, <linux-kernel@...>, <linux-rt-users@...>, <dipankar@...>, <ego@...>, <paulmck@...>, Andrew Morton <akpm@...>
Date: Monday, January 14, 2008 - 12:30 pm

On Mon, 14 Jan 2008, Mathieu Desnoyers wrote:

Last I saw, it generates crappy code, with lots more jumps back and forth, 
and the image just blows up.

There's a reason we use -Os, and that's that small footprint I$ is 
generally more important than fake compiler optimizations that don't 
actually help except on microbenchmarks where everything fits in the 
cache.

Taking a branch instruction from two bytes to five is almost always a 
mistake, unless you *know* that the code it jumps to will effectively 
never be done at all (which is not necessarily the case at all). It also 
makes debugging much nastier, because if now things like backtraces 
probably look like crap too!

Don't go there. The *best* we can do is to just use the optimizations that 
generate good-looking code that humans can read. The rest is just compiler 
masturbation.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost..., Mathieu Desnoyers, (Thu Jan 3, 12:30 pm)
Re: Markers: multi-probe locking fun (was: Re: [PATCH 0/2] M..., Mathieu Desnoyers, (Tue Feb 19, 6:03 pm)
Re: Markers: multi-probe locking fun (was: Re: [PATCH 0/2] M..., Mathieu Desnoyers, (Tue Feb 19, 4:33 pm)
Re: Markers: multi-probe locking fun (was: Re: [PATCH 0/2] M..., Mathieu Desnoyers, (Tue Feb 19, 6:32 pm)
Re: [PATCH 0/2] Markers Implementation for RCU Tracing - Ver..., Mathieu Desnoyers, (Mon Feb 18, 4:41 pm)
Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost..., Mathieu Desnoyers, (Mon Jan 14, 11:35 am)
Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost..., Linus Torvalds, (Mon Jan 14, 12:30 pm)
Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost..., Mathieu Desnoyers, (Mon Jan 14, 3:36 pm)