login
Header Space

 
 

Re: [PATCH 002 of 6] md: Fix use-after-free bug when dropping an rdev from an md array.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Neil Brown <neilb@...>
Cc: Andrew Morton <akpm@...>, <linux-raid@...>, <linux-kernel@...>
Date: Monday, January 14, 2008 - 9:56 am

On Mon, Jan 14, 2008 at 12:59:39PM +0000, Al Viro wrote:


More fun questions: what are the locking requirements for ->resize()?
You are calling it with no exclusion whatsoever...  What about
bind_rdev_to_array()?  At the very least, you want to protect
mddev->disks, and AFAICS new_dev_store() has no exclusion at all.
And I suspect that you have other things in there in need of protection
(finding free desc_nr, for one); can all of those be handled by simple
spinlocks?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 002 of 6] md: Fix use-after-free bug when droppin..., Al Viro, (Mon Jan 14, 9:56 am)
speck-geostationary