Seeking best source of meds? All you need you can find here: WWW.ALLSEEK.TK --

This happens when trying to compile memory stick support inside the kernel. drivers/memstick/core/mspro_block.o: In function `memstick_priv': mspro_block.c:(.text+0x0): multiple definition of `memstick_priv' drivers/memstick/core/memstick.o:memstick.c:(.text+0x0): first defined here drivers/memstick/core/mspro_block.o: In function `memstick_get_drvdata': mspro_block.c:(.text+0x6): multiple definition of `memstick_get_drvdata' drivers/memstick/core/memstick.o:memstick.c:(.text+0x6): first defined her...

I would suggest dropping it. Having unnecessary code is likely to be confusing. NeilBrown --

In another thread I mentioned the idea to introduce additional sections for all the __init markers. Introducing checks for all the new combinations in modpost turned out to be difficult so I decided to clean up what we have today by introducing a table based approach. The patch below is the result of this effort. I have pushed out kbuild.git with this change so grab it there if you like to play with it. Comments are welcome. The pattern_cmp() includes support for "*foo*" but that is not yet ...

First please always send cleanup patches separately. I think you have more than just the C99 conversion. Were you even able to compile it? Since ip27 is ia64 only that would need an IA64 cross compiler or a native ia64 machine. It's probably better to focus on drivers only that actually build on x86 :- see http://www.halobates.de/allyes for a compile log showing all buildable files for x86-64 and i386. Other than that the patch looks ok to me, but I haven't tried to compile it either. -...

s/parameters/variables/; too sleeeepy. --

Looks like it can be dropped here. All usage of rtc-> is done under rtc_lock. Every other variable there is thread-local. --

Hi Bart, here are the remaining patches which had issues to be worked out. I decided to keep the Flexible Disk Page and Capacity Descriptor in idefloppy_floppy_t for the sake of the two printk calls for which they are used. Otherwise, we'll be changing long-known driver behavior and this won't be acceptable. I'll audit the driver to see whether rq_data_dir() can replace the PC_WRITING flag completely and get rid of that one too. By the way, I have an Iomega ZIP 100 drive somewhere in my hardware ...

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> --- drivers/ide/ide-floppy.c | 90 ++++++++++++++++++--------------------------- 1 files changed, 36 insertions(+), 54 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 7648684..06d83cb 100644 --- a/drivers/ide/ide-floppy.c +++ b/drivers/ide/ide-floppy.c @@ -120,33 +120,6 @@ typedef struct idefloppy_packet_command_s { #define PC_SUPPRESS_ERROR 6 /* Suppress error reporting */ /* - * Flexible disk...

By passing idefloppy_floppy_t *floppy to the factored out functions, we get rid of (almost) all local vars so stack usage should be at minimum here. Also, we merge idefloppy_begin_format() into idefloppy_format_start() since it is its only user. Also, rename idefloppy_format_start() to idefloppy_format_unit(). Finally, rename the reworked functions to ide_floppy..(). Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> --- drivers/ide/ide-floppy.c | 153 +++++++++++++++++++++++----------------...

In addition to shortening the function name, move the printk-call into the function thereby saving some code lines. Also, make the function out_of_line since it is not on a performance critical path. Finally, rename the reworked function to ide_floppy..(). Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> --- drivers/ide/ide-floppy.c | 38 ++++++++++++++------------------------ 1 files changed, 14 insertions(+), 24 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-fl...

We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by introducing a 4th arg. called direction. According to its value we atapi_input_bytes() or atapi_output_bytes(). Also, this simplifies the interrupt handler logic a bit. Finally, rename idefloppy_io_buffers() to ide_floppy_io_buffers(). Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> --- drivers/ide/ide-floppy.c | 67 +++++++++++++-------------------------------- 1 files changed, 20 insertions(+), 47 deletions(-)...

..and replace them with flag enums. Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de> --- drivers/ide/ide-floppy.c | 132 +++++++++++++++++++++++++-------------------- 1 files changed, 73 insertions(+), 59 deletions(-) diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index 790e33f..8e7714a 100644 --- a/drivers/ide/ide-floppy.c +++ b/drivers/ide/ide-floppy.c @@ -107,16 +107,21 @@ typedef struct idefloppy_packet_command_s { unsigned long flags; /* Status/Action bit f...

such as ERROR: switch and case should be at the same indent ERROR: need spaces around that '=' (ctx:VxV) ERROR: trailing statements should be on next line WARNING: no space between function name and open parenthesis '(' WARNING: printk() should include KERN_ facility level ERROR: That open brace { should be on the previous line ERROR: use tabs not spaces ERROR: do not use assignment in if condition WARNING: braces {} are not necessary for single statement blocks ERROR: need space after that ',' (c...

Up and running here. No significant testing but no problems building it and no obvious regressions from 2.6.24-rc2-rt1. mark@lightning ~ $ uname -a Linux lightning 2.6.24-rc7-rt1 #1 PREEMPT RT Sun Jan 13 14:41:21 PST 2008 x86_64 AMD Athlon(tm) 64 Processor 3000+ AuthenticAMD GNU/Linux mark@lightning ~ $ - Mark --

Servers me right for releasing without testing more than one config. I compiled for x86_64, i386 and PPC 32 and 64, but all without any tracing on. And I should have since I modified that a bit. OK, -rt2 will take a bit more beating from me before I release it, so it might take some time to get it out (expect it out on Monday). -- Steve --

That doesn't look too bad. Or is over a 100us not good for that box? Yeah, I didn't make any attempt to fix latency_tracing for PPC on this release. I expected as much. I do have a couple of PPC boxes that I can play with, and I'll see if I can get that working too before -rt2. But I want to get a stable x86 release out fast. Thanks, -- Steve --

Ouch! <looks at rejs> *************** static inline void __quicklist_free(int *** 76,86 **** return; } - q = &get_cpu_var(quicklist)[nr]; *(void **)p = q->page; q->page = p; q->nr_pages++; - put_cpu_var(quicklist); } static inline void quicklist_free(int nr, void (*dtor)(void *), void *pp) --- 73,83 ---- return; } + q = &get_cpu_var_locked(quicklist, &cpu)[nr]; *(void **)p = q->page; q->page = p; q->nr...

Change the following static arrays sized by NR_CPUS to per_cpu data variables: acpi_cpufreq_data *drv_data[NR_CPUS] Signed-off-by: Mike Travis <travis@sgi.com> Reviewed-by: Christoph Lameter <clameter@sgi.com> --- arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c @@ -67,7 +67,8 @@ struct acpi_cpufreq_data ...

So, you think some machine is going to have more than 256 nodes ? If so, you probably need to change 'struct memnode' too (include/asm-x86/mmzone_64.h) --

Change the following static arrays sized by NR_CPUS to per_cpu data variables: powernow_k8_data *powernow_data[NR_CPUS]; Signed-off-by: Mike Travis <travis@sgi.com> Reviewed-by: Christoph Lameter <clameter@sgi.com> --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c @@ -53,7 +53,7 @@ /* serialize freq changes */ st...

Change the following static arrays sized by NR_CPUS to per_cpu data variables: i386_cpu cpu_devices[NR_CPUS]; (And change the struct name to x86_cpu.) Signed-off-by: Mike Travis <travis@sgi.com> Reviewed-by: Christoph Lameter <clameter@sgi.com> --- arch/x86/kernel/topology.c | 8 ++++---- include/asm-x86/cpu.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -31,7 +31,7 @@ #include &lt...

Clean up references to x86_cpu_to_apicid. Removes extraneous comments and standardizes on "x86_*_early_ptr" for the early kernel init references. Signed-off-by: Mike Travis <travis@sgi.com> Reviewed-by: Christoph Lameter <clameter@sgi.com> --- arch/x86/kernel/genapic_64.c | 11 ++--------- arch/x86/kernel/mpparse_64.c | 11 +++-------- arch/x86/kernel/setup_64.c | 2 +- arch/x86/kernel/smpboot_32.c | 9 ++------- arch/x86/kernel/smpboot_64.c | 16 +++++++++------- in...

Change the following static arrays sized by NR_CPUS to per_cpu data variables: _cpuid4_info *cpuid4_info[NR_CPUS]; _index_kobject *index_kobject[NR_CPUS]; kobject * cache_kobject[NR_CPUS]; Signed-off-by: Mike Travis <travis@sgi.com> Reviewed-by: Christoph Lameter <clameter@sgi.com> --- arch/x86/kernel/cpu/intel_cacheinfo.c | 55 +++++++++++++++++----------------- 1 file changed, 29 insertions(+), 26 deletions(-) --- a/arch/x86/kernel/cpu/intel_cacheinfo.c +++ b/arch/x86/ke...

Another potential user of that I can see is the DRM. Nowadays, graphic cards essentially have an MMU on chip, and can do paging. It would be nice to be able to map user objects in them without having to lock them down using your callback to properly mark them cast out on the card. Ben. --