Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Cyrill Gorcunov <gorcunov@...>
Cc: Paul Gortmaker <p_gortmaker@...>, LKML <linux-kernel@...>
Date: Sunday, January 13, 2008 - 7:08 pm

On Sunday 13 January 2008 21:32:23 Cyrill Gorcunov wrote:


First please always send cleanup patches separately. I think you have more
than just the C99 conversion.

Were you even able to compile it? Since ip27 is ia64 only that would need 
an IA64 cross compiler or a native ia64 machine.

It's probably better to focus on drivers only that actually build
on x86 :- see http://www.halobates.de/allyes for a compile log
showing all buildable files for x86-64 and i386.

Other than that the patch looks ok to me, but I haven't tried to 
compile it either.

-Andi
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl, Cyrill Gorcunov, (Sun Jan 13, 4:32 pm)
Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl, Andi Kleen, (Sun Jan 13, 7:08 pm)