[PATCH 9/12] ide-floppy: remove unused IDEFLOPPY_USE_READ12

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <bzolnier@...>
Cc: <linux-kernel@...>, <linux-ide@...>, Borislav Petkov <bbpetkov@...>
Date: Sunday, January 13, 2008 - 4:18 pm

This flag is not being set anywhere in the driver so it can go.

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
---
 drivers/ide/ide-floppy.c |   17 ++++++-----------
 1 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 6c917fc..790e33f 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -180,7 +180,6 @@ typedef struct ide_floppy_obj {
  */
 #define IDEFLOPPY_DRQ_INTERRUPT		0	/* DRQ interrupt device */
 #define IDEFLOPPY_MEDIA_CHANGED		1	/* Media may have changed */
-#define IDEFLOPPY_USE_READ12		2	/* Use READ12/WRITE12 or READ10/WRITE10 */
 #define	IDEFLOPPY_FORMAT_IN_PROGRESS	3	/* Format in progress */
 #define IDEFLOPPY_CLIK_DRIVE	        4       /* Avoid commands not supported in Clik drive */
 #define IDEFLOPPY_ZIP_DRIVE		5	/* Requires BH algorithm for packets */
@@ -889,25 +888,21 @@ static void idefloppy_create_test_unit_ready_cmd(idefloppy_pc_t *pc)
 	pc->c[0] = GPCMD_TEST_UNIT_READY;
 }
 
-static void idefloppy_create_rw_cmd (idefloppy_floppy_t *floppy, idefloppy_pc_t *pc, struct request *rq, unsigned long sector)
+static void idefloppy_create_rw_cmd(idefloppy_floppy_t *floppy,
+		idefloppy_pc_t *pc, struct request *rq, unsigned long sector)
 {
 	int block = sector / floppy->bs_factor;
 	int blocks = rq->nr_sectors / floppy->bs_factor;
 	int cmd = rq_data_dir(rq);
 
-	debug_log("create_rw1%d_cmd: block == %d, blocks == %d\n",
-		2 * test_bit (IDEFLOPPY_USE_READ12, &floppy->flags),
+	debug_log("create_rw10_cmd: block == %d, blocks == %d\n",
 		block, blocks);
 
 	idefloppy_init_pc(pc);
-	if (test_bit(IDEFLOPPY_USE_READ12, &floppy->flags)) {
-		pc->c[0] = cmd == READ ? GPCMD_READ_12 : GPCMD_WRITE_12;
-		put_unaligned(cpu_to_be32(blocks), (unsigned int *) &pc->c[6]);
-	} else {
-		pc->c[0] = cmd == READ ? GPCMD_READ_10 : GPCMD_WRITE_10;
-		put_unaligned(cpu_to_be16(blocks), (unsigned short *)&pc->c[7]);
-	}
+	pc->c[0] = cmd == READ ? GPCMD_READ_10 : GPCMD_WRITE_10;
+	put_unaligned(cpu_to_be16(blocks), (unsigned short *)&pc->c[7]);
 	put_unaligned(cpu_to_be32(block), (unsigned int *) &pc->c[2]);
+
 	pc->callback = &idefloppy_rw_callback;
 	pc->rq = rq;
 	pc->b_count = cmd == READ ? 0 : rq->bio->bi_size;
-- 
1.5.3.7

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/12] ide-floppy redux v2.5, Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 0/12] ide-floppy redux v2.5, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:38 pm)
Re: [PATCH 0/12] ide-floppy redux v2.5, Borislav Petkov, (Sun Jan 20, 8:38 am)
Re: [PATCH 0/12] ide-floppy redux v2.5, Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 6:45 pm)
Re: [PATCH 0/12] ide-floppy redux v2.5, Borislav Petkov, (Tue Jan 22, 1:32 am)
[PATCH 6/12] ide-floppy: mv idefloppy_{should_,}report_error, Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 7/12] ide-floppy: remove IDEFLOPPY_DEBUG_BUGS macro, Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_..., Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:38 pm)
[PATCH 9/12] ide-floppy: remove unused IDEFLOPPY_USE_READ12, Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:50 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Tue Jan 15, 4:10 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Wed Jan 16, 6:25 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Tue Jan 15, 3:07 am)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 6:32 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Tue Jan 15, 4:09 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Wed Jan 16, 6:08 pm)
[PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO, Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:51 pm)
Re: (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the ..., Bartlomiej Zolnierkiewicz..., (Wed Jan 16, 6:51 pm)