Home » Mailing list archives » linux-kernel » 2008 » January » 13

[PATCH 5/12] ide-floppy: report DMA handling in idefloppy_pc_intr() properly

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Borislav Petkov <bbpetkov@...>
To: <bzolnier@...>
Cc: <linux-kernel@...>, <linux-ide@...>, Borislav Petkov <bbpetkov@...>
Subject: [PATCH 5/12] ide-floppy: report DMA handling in idefloppy_pc_intr() properly
Date: Sunday, January 13, 2008 - 4:18 pm

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
---
 drivers/ide/ide-floppy.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 00ea8d6..5004773 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -534,11 +534,17 @@ static ide_startstop_t idefloppy_pc_intr (ide_drive_t *drive)
 	unsigned int temp;
 	u16 bcount;
 	u8 stat, ireason;
+	int dma_error = 0;
 
 	debug_log("Reached %s interrupt handler\n", __FUNCTION__);
 
 	if (test_bit(PC_DMA_IN_PROGRESS, &pc->flags)) {
-		if (HWIF(drive)->ide_dma_end(drive)) {
+		dma_error = HWIF(drive)->ide_dma_end(drive);
+		if (dma_error) {
+			printk(KERN_ERR "%s: DMA %s error\n",
+				drive->name,
+				rq_data_dir(rq) == WRITE ? "write" :"read");
+
 			set_bit(PC_DMA_ERROR, &pc->flags);
 		} else {
 			pc->actually_transferred = pc->request_transfer;
-- 
1.5.3.7

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/12] ide-floppy redux v2.5, Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 0/12] ide-floppy redux v2.5, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:38 pm)
Re: [PATCH 0/12] ide-floppy redux v2.5, Borislav Petkov, (Sun Jan 20, 8:38 am)
Re: [PATCH 0/12] ide-floppy redux v2.5, Bartlomiej Zolnierkiewicz..., (Mon Jan 21, 6:45 pm)
Re: [PATCH 0/12] ide-floppy redux v2.5, Borislav Petkov, (Tue Jan 22, 1:32 am)
[PATCH 1/12] ide-floppy: remove struct idefloppy_mode_parame..., Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 2/12] ide-floppy: remove struct idefloppy_flexible_di..., Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 3/12] ide-floppy: remove struct idefloppy_capacity_de..., Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 4/12] ide-floppy: factor out ioctl handlers from idef..., Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 5/12] ide-floppy: report DMA handling in idefloppy_pc..., Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 6/12] ide-floppy: mv idefloppy_{should_,}report_error, Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 7/12] ide-floppy: remove IDEFLOPPY_DEBUG_BUGS macro, Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buff..., Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_..., Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:38 pm)
Re: [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_..., Borislav Petkov, (Tue Jan 15, 3:14 am)
[PATCH 9/12] ide-floppy: remove unused IDEFLOPPY_USE_READ12, Borislav Petkov, (Sun Jan 13, 4:18 pm)
[PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:50 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Tue Jan 15, 4:10 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Wed Jan 16, 6:25 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Tue Jan 15, 3:07 am)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 6:32 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Borislav Petkov, (Tue Jan 15, 4:09 pm)
Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros, Bartlomiej Zolnierkiewicz..., (Wed Jan 16, 6:08 pm)
[PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO, Borislav Petkov, (Sun Jan 13, 4:18 pm)
Re: [PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO, Bartlomiej Zolnierkiewicz..., (Mon Jan 14, 5:51 pm)
[PATCH 12/12] ide-floppy: fix most of the remaining checkpat..., Borislav Petkov, (Sun Jan 13, 4:18 pm)
(was: Re:...) [PATCH 12/12] ide-floppy: fix most of the rema..., Borislav Petkov, (Tue Jan 15, 4:12 pm)
Re: (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the ..., Bartlomiej Zolnierkiewicz..., (Wed Jan 16, 6:51 pm)