Re: 2.6.24-rc7-rt1: macro "put_cpu_var" passed 2 arguments, but takes just 1

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Steven Rostedt <rostedt@...>
Cc: LKML <linux-kernel@...>, RT <linux-rt-users@...>, Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>
Date: Sunday, January 13, 2008 - 3:53 pm

Hello,


  CC      arch/x86/mm/init_32.o
In file included from include/asm-generic/tlb.h:17,
                 from include/asm/tlb.h:9,
                 from arch/x86/mm/init_32.c:43:
include/linux/quicklist.h:73:28: error: macro "put_cpu_var" passed 2 arguments, but takes just 1
In file included from include/asm-generic/tlb.h:17,
                 from include/asm/tlb.h:9,
                 from arch/x86/mm/init_32.c:43:
include/linux/quicklist.h: In function '__quicklist_free':
include/linux/quicklist.h:73: error: 'put_cpu_var' undeclared (first use in this function)
include/linux/quicklist.h:73: error: (Each undeclared identifier is reported only once
include/linux/quicklist.h:73: error: for each function it appears in.)
make[1]: *** [arch/x86/mm/init_32.o] Error 1
make: *** [arch/x86/mm] Error 2

--- linux-2.6.24-rc7-rt1.orig/include/linux/quicklist.h 2008-01-11 21:16:22.000000000 -0500
+++ linux-2.6.24-rc7-rt1/include/linux/quicklist.h      2008-01-11 21:18:08.000000000 -0500
@@ -18,7 +18,7 @@ struct quicklist {
        int nr_pages;
 };

[... snip ...]

@@ -56,12 +64,13 @@ static inline void __quicklist_free(int 
        struct page *page)
 {
        struct quicklist *q;
+       int cpu;

-       q = &get_cpu_var(quicklist)[nr];
+       q = &get_cpu_var_locked(quicklist, &cpu)[nr];
        *(void **)p = q->page;
        q->page = p;
        q->nr_pages++;
-       put_cpu_var(quicklist);
+       put_cpu_var(quicklist, cpu); <------------- should that be put_cpu_var_locked()?
 }

Regards,

	Mariusz
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc7-rt1, Steven Rostedt, (Sun Jan 13, 3:00 pm)
Re: 2.6.24-rc7-rt1, Mark Knecht, (Sun Jan 13, 6:56 pm)
Re: 2.6.24-rc7-rt1, Mariusz Kozlowski, (Sun Jan 13, 4:43 pm)
Re: 2.6.24-rc7-rt1, Steven Rostedt, (Sun Jan 13, 4:54 pm)
Re: 2.6.24-rc7-rt1, Mike Galbraith, (Mon Jan 14, 4:27 am)
Re: 2.6.24-rc7-rt1, S.Çağlar, (Mon Jan 14, 2:39 pm)
Re: 2.6.24-rc7-rt1, Steven Rostedt, (Mon Jan 14, 12:52 pm)
Re: 2.6.24-rc7-rt1, Gregory Haskins, (Mon Jan 14, 8:13 am)
Re: 2.6.24-rc7-rt1, Mike Galbraith, (Mon Jan 14, 9:25 am)
Re: 2.6.24-rc7-rt1, Mike Galbraith, (Tue Jan 15, 4:07 am)
Re: 2.6.24-rc7-rt1, Mike Galbraith, (Tue Jan 15, 5:28 am)
Re: 2.6.24-rc7-rt1, Gregory Haskins, (Tue Jan 15, 12:50 pm)
Re: 2.6.24-rc7-rt1, Mike Galbraith, (Mon Jan 14, 10:29 am)
Re: 2.6.24-rc7-rt1, Robert Schwebel, (Sun Jan 13, 4:25 pm)
Re: 2.6.24-rc7-rt1, Steven Rostedt, (Sun Jan 13, 4:48 pm)
Re: 2.6.24-rc7-rt1, Robert Schwebel, (Mon Jan 14, 3:49 pm)
Re: 2.6.24-rc7-rt1: macro "put_cpu_var" passed 2 arguments, ..., Mariusz Kozlowski, (Sun Jan 13, 3:53 pm)