Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: WANG Cong <xiyou.wangcong@...>
Cc: Sam Ravnborg <sam@...>, Andreas Schwab <schwab@...>, LKML <linux-kernel@...>, <linux-kbuild@...>, Andrew Morton <akpm@...>, <linux-mips@...>
Date: Friday, January 11, 2008 - 10:17 am

On Wed, Jan 02, 2008 at 02:21:36PM +0800, WANG Cong wrote:


LDSCRIPT also needed fixing to get builds in a separate object directory
working again.

I've applied below fix.

  Ralf

From 8babf06e1265214116fb8ffc634c04df85597c52 Mon Sep 17 00:00:00 2001
From: WANG Cong <xiyou.wangcong@gmail.com>
Date: Wed, 2 Jan 2008 14:21:36 +0800
Subject: [PATCH] [MIPS] Lasat: Fix built in separate object directory.

Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

[Ralf: The LDSCRIPT script needed fixing, too]

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/lasat/image/Makefile b/arch/mips/lasat/image/Makefile
index 5332449..7ccd40d 100644
--- a/arch/mips/lasat/image/Makefile
+++ b/arch/mips/lasat/image/Makefile
@@ -12,11 +12,11 @@ endif
 
 MKLASATIMG = mklasatimg
 MKLASATIMG_ARCH = mq2,mqpro,sp100,sp200
-KERNEL_IMAGE = $(TOPDIR)/vmlinux
+KERNEL_IMAGE = vmlinux
 KERNEL_START = $(shell $(NM) $(KERNEL_IMAGE) | grep " _text" | cut -f1 -d\ )
 KERNEL_ENTRY = $(shell $(NM) $(KERNEL_IMAGE) | grep kernel_entry | cut -f1 -d\ )
 
-LDSCRIPT= -L$(obj) -Tromscript.normal
+LDSCRIPT= -L$(srctree)/$(obj) -Tromscript.normal
 
 HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \
 		-D_kernel_entry=0x$(KERNEL_ENTRY) \
@@ -24,7 +24,7 @@ HEAD_DEFINES := -D_kernel_start=0x$(KERNEL_START) \
 		-D TIMESTAMP=$(shell date +%s)
 
 $(obj)/head.o: $(obj)/head.S $(KERNEL_IMAGE)
-	$(CC) -fno-pic $(HEAD_DEFINES) -I$(TOPDIR)/include -c -o $@ $<
+	$(CC) -fno-pic $(HEAD_DEFINES) $(LINUXINCLUDE) -c -o $@ $<
 
 OBJECTS = head.o kImage.o
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[Patch 0/8] Remove 'TOPDIR' from Makefiles, WANG Cong, (Tue Jan 1, 3:13 am)
Re: [Patch 0/8] Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Wed Jan 2, 5:51 am)
Re: [Patch 0/8] Remove 'TOPDIR' from Makefiles, WANG Cong, (Thu Jan 3, 12:37 am)
Re: [Patch 0/8] Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:09 am)
[Patch 8/8] Remove 'TOPDIR' from the Top Makefile, WANG Cong, (Tue Jan 1, 3:43 am)
[Patch 7/8] FS: Remove 'TOPDIR' from Makefiles, WANG Cong, (Tue Jan 1, 3:41 am)
(Try #3) [Patch 7/8] FS: Remove dead code, WANG Cong, (Wed Jan 2, 1:55 am)
Re: [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:30 am)
[Patch 6/8] FRV: Remove 'TOPDIR' from Makefiles, WANG Cong, (Tue Jan 1, 3:36 am)
Re: [Patch 6/8] FRV: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:27 am)
[Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles, WANG Cong, (Tue Jan 1, 3:29 am)
Re: [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:20 am)
[Patch 3/8] S390: Remove 'TOPDIR' from Makefiles, WANG Cong, (Tue Jan 1, 3:25 am)
Re: [Patch 3/8] S390: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:17 am)
Re: (Try #2) [Patch 3/8] S390: Tiny fixes for Makefile, Sam Ravnborg, (Tue Jan 1, 1:42 pm)
Re: (Try #3) [Patch 3/8] S390: Remove 'TOPDIR' from Makefile, Martin Schwidefsky, (Wed Jan 2, 5:31 am)
[Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, WANG Cong, (Tue Jan 1, 3:22 am)
Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:15 am)
Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Andreas Schwab, (Tue Jan 1, 9:44 am)
Re: [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 1:57 pm)
Re: (Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles, Ralf Baechle, (Fri Jan 11, 10:17 am)
[Patch 1/8] UML: Remove 'TOPDIR' from Makefiles, WANG Cong, (Tue Jan 1, 3:18 am)
Re: [Patch 1/8] UML: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:33 am)
Re: [Patch 1/8] UML: Remove 'TOPDIR' from Makefiles, Sam Ravnborg, (Tue Jan 1, 6:49 am)