Re: [PATCH wireless/arlan] Replace logical- by bit-and

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Roel Kluin <12o3l@...>

To: Randy Dunlap <randy.dunlap@...>

Cc: <linville@...>, lkml <linux-kernel@...>, <linux-wireless@...>, <Elmer.Joandi@...>, <c.jennings@...>

Subject: Re: [PATCH wireless/arlan] Replace logical- by bit-and

Date: Thursday, January 10, 2008 - 6:19 pm

Randy Dunlap wrote:
quoted text> On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote:
> 
>> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h
>> index 3ed1df7..7b7498f 100644
>> --- a/drivers/net/wireless/arlan.h
>> +++ b/drivers/net/wireless/arlan.h
>> @@ -485,7 +485,7 @@ struct arlan_private {
>>  #define clearClearInterrupt(dev){\
>>     writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);}
>>  #define setPowerOff(dev){\
>> -   writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\
>> +   writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\
> 
> eh?  How does that help?

Right, sorry, please ignore my patch.

quoted text> Maybe it should be (ARLAN_POWER | ARLAN_ACCESS), but some
> arlan developer or someone with specs should help here...

I have CC'd the previous maintainers
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH wireless/arlan] Replace logical- by bit-and, Roel Kluin, (Thu Jan 10, 3:15 pm)

Re: [PATCH wireless/arlan] Replace logical- by bit-and, Randy Dunlap, (Thu Jan 10, 4:28 pm)

Re: [PATCH wireless/arlan] Replace logical- by bit-and, Roel Kluin, (Thu Jan 10, 6:19 pm)

Re: [PATCH wireless/arlan] Replace logical- by bit-and, Chuck Ebbert, (Thu Jan 10, 4:48 pm)

Re: [PATCH wireless/arlan] Replace logical- by bit-and, Randy Dunlap, (Thu Jan 10, 5:16 pm)

Re: [PATCH wireless/arlan] Replace logical- by bit-and, John W. Linville, (Thu Jan 10, 5:28 pm)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 004/196] Chinese: add translation of SubmittingPatches
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Eric Sandeen	Re: [RFC] Heads up on sys_fallocate()
git:

linux-netdev:
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Antonio Almeida	HTB accuracy for high speed
openbsd-misc:

Colocation donated by:

Online users

henrywatson

Syndicate