[PATCH 2/4] PM: Do not destroy/create devices while suspended in msr.c (rev. 2)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: pm list <linux-pm@...>
Cc: ACPI Devel Maling List <linux-acpi@...>, Alan Stern <stern@...>, Andrew Morton <akpm@...>, Len Brown <lenb@...>, LKML <linux-kernel@...>, Pavel Machek <pavel@...>, Ingo Molnar <mingo@...>, Greg KH <gregkh@...>
Date: Tuesday, January 1, 2008 - 7:40 pm

From: Rafael J. Wysocki <rjw@sisk.pl>

The MSR driver should not attempt to destroy/create a device while
suspended, unless this device corresponds to a nonboot CPU that
failed to go online during a resume, in which case the PM core should
be asked to remove it.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 arch/x86/kernel/msr.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/arch/x86/kernel/msr.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/msr.c
+++ linux-2.6/arch/x86/kernel/msr.c
@@ -155,15 +155,15 @@ static int __cpuinit msr_class_cpu_callb
 
 	switch (action) {
 	case CPU_UP_PREPARE:
-	case CPU_UP_PREPARE_FROZEN:
 		err = msr_device_create(cpu);
 		break;
 	case CPU_UP_CANCELED:
-	case CPU_UP_CANCELED_FROZEN:
 	case CPU_DEAD:
-	case CPU_DEAD_FROZEN:
 		msr_device_destroy(cpu);
 		break;
+	case CPU_UP_CANCELED_FROZEN:
+		destroy_suspended_device(msr_class, MKDEV(MSR_MAJOR, cpu));
+		break;
 	}
 	return err ? NOTIFY_BAD : NOTIFY_OK;
 }

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 0/4] PM: Do not destroy/create devices while susp..., Rafael J. Wysocki, (Sat Jan 12, 7:20 am)
Re: [PATCH 0/4] PM: Do not destroy/create devices while susp..., Rafael J. Wysocki, (Sat Jan 12, 7:25 am)
[PATCH 2/4] PM: Do not destroy/create devices while suspende..., Rafael J. Wysocki, (Tue Jan 1, 7:40 pm)
[PATCH 1/4] PM: Introduce destroy_suspended_device(), Rafael J. Wysocki, (Tue Jan 1, 7:34 pm)
Re: [PATCH 1/4] PM: Introduce destroy_suspended_device(), Rafael J. Wysocki, (Wed Jan 2, 9:33 am)
Re: [PATCH 1/4] PM: Introduce destroy_suspended_device(), Rafael J. Wysocki, (Wed Jan 2, 12:50 pm)
Re: [PATCH 1/4] PM: Introduce destroy_suspended_device(), Rafael J. Wysocki, (Fri Jan 4, 6:05 pm)
Re: [PATCH 1/4] PM: Introduce destroy_suspended_device(), Rafael J. Wysocki, (Sat Jan 5, 7:55 am)