[2.6 patch] make sctp_addto_param() static

Previous thread: [-mm patch] unexport sys_{open,read} by Adrian Bunk on Sunday, September 9, 2007 - 1:25 pm. (26 messages)

Next thread: [PATCH -mm 0/5] Hibernation: Clean up userland interface (rev. 2) by Rafael J. Wysocki on Sunday, September 9, 2007 - 1:57 pm. (8 messages)
From: Adrian Bunk
Date: Sunday, September 9, 2007 - 1:25 pm

sctp_addto_param() can become static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 include/net/sctp/structs.h |    1 
 net/sctp/sm_make_chunk.c   |   39 ++++++++++++++++++-------------------
 2 files changed, 20 insertions(+), 20 deletions(-)

38f8064114b9e89a6a911b2e3625a41cdb477bcd 
diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index c0d5848..ee4559b 100644
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -726,7 +726,6 @@ int sctp_user_addto_chunk(struct sctp_chunk *chunk, int off, int len,
 			  struct iovec *data);
 void sctp_chunk_free(struct sctp_chunk *);
 void  *sctp_addto_chunk(struct sctp_chunk *, int len, const void *data);
-void  *sctp_addto_param(struct sctp_chunk *, int len, const void *data);
 struct sctp_chunk *sctp_chunkify(struct sk_buff *,
 				 const struct sctp_association *,
 				 struct sock *);
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 79856c9..cf3b560 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -839,6 +839,26 @@ err_chunk:
 	return retval;
 }
 
+/* Append bytes to the end of a parameter.  Will panic if chunk is not big
+ * enough.
+ */
+static void *sctp_addto_param(struct sctp_chunk *chunk, int len,
+			      const void *data)
+{
+	void *target;
+	int chunklen = ntohs(chunk->chunk_hdr->length);
+
+	target = skb_put(chunk->skb, len);
+
+	memcpy(target, data, len);
+
+	/* Adjust the chunk length field.  */
+	chunk->chunk_hdr->length = htons(chunklen + len);
+	chunk->chunk_end = skb_tail_pointer(chunk->skb);
+
+	return target;
+}
+
 /* Make an ABORT chunk with a PROTOCOL VIOLATION cause code. */
 struct sctp_chunk *sctp_make_abort_violation(
 	const struct sctp_association *asoc,
@@ -1146,25 +1166,6 @@ void *sctp_addto_chunk(struct sctp_chunk *chunk, int len, const void *data)
 	return target;
 }
 
-/* Append bytes to the end of a parameter.  Will panic if chunk is not big
- * enough.
- */
-void *sctp_addto_param(struct ...
From: Vlad Yasevich
Date: Monday, September 10, 2007 - 6:40 am

Ack

-vlad
-

From: Neil Horman
Date: Monday, September 10, 2007 - 6:42 am

ACK, seems reasonable to me.
Neil


-- 
/***************************************************
 *Neil Horman
 *nhorman@tuxdriver.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
-

From: David Miller
Date: Wednesday, September 12, 2007 - 6:17 am

From: Adrian Bunk <bunk@kernel.org>

Applied, thanks.
-

Previous thread: [-mm patch] unexport sys_{open,read} by Adrian Bunk on Sunday, September 9, 2007 - 1:25 pm. (26 messages)

Next thread: [PATCH -mm 0/5] Hibernation: Clean up userland interface (rev. 2) by Rafael J. Wysocki on Sunday, September 9, 2007 - 1:57 pm. (8 messages)