Home » Mailing list archives » linux-kernel » 2007 » September » 9

Re: [-mm patch] unexport sys_{open,read}

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Arjan van de Ven <arjan@...>
To: Adrian Bunk <bunk@...>
Cc: Andrew Morton <akpm@...>, Christoph Hellwig <hch@...>, <perex@...>, <linux-kernel@...>
Subject: Re: [-mm patch] unexport sys_{open,read}
Date: Sunday, September 9, 2007 - 6:41 pm

On Mon, 10 Sep 2007 00:22:03 +0200
Adrian Bunk <bunk@kernel.org> wrote:




Adrian,

as much as I personally disagree with Andrew's policy here (esp for
these symbols, they have been deprecated for years now), it's trivial
to just follow his requirements and get this over with.

As for who cares.. I do care still, unused exports make the kernel
bigger for everyone, and for the most cases, encourage incorrect APIs
to be used by driver writers (they act as a trap; the symbols generally
are not used by anything in the kernel because they're the wrong API to
use for drivers; having them exported wrongly suggests to new driver
writers that they are good things to use). I plan to do another run of
finding all unused exports and just marking the lot as _UNUSED  exports.
(that's not the same as removing them quite yet, but at least it's a
good warning for driver writers that they should think twice about the
API to see if it's the right one to use)


Greetings,
    Arjan van de Ven
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[-mm patch] unexport sys_{open,read}, Adrian Bunk, (Sun Sep 9, 4:25 pm)
Re: [-mm patch] unexport sys_{open,read}, Christoph Hellwig, (Sun Sep 9, 4:39 pm)
Re: [-mm patch] unexport sys_{open,read}, David Miller, (Mon Sep 10, 8:18 am)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Tue Sep 18, 10:10 am)
Re: [-mm patch] unexport sys_{open,read}, Christoph Hellwig, (Mon Sep 10, 8:21 am)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Sun Sep 9, 5:59 pm)
Re: [-mm patch] unexport sys_{open,read}, Christoph Hellwig, (Mon Sep 10, 5:08 am)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 5:23 am)
Re: [-mm patch] unexport sys_{open,read}, Arjan van de Ven, (Mon Sep 10, 11:14 am)
Re: [-mm patch] unexport sys_{open,read}, Dave Jones, (Tue Sep 25, 5:17 pm)
Re: [-mm patch] unexport sys_{open,read}, Al Viro, (Mon Sep 10, 8:43 am)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 1:25 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 3:58 pm)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 4:17 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 6:18 pm)
Re: [-mm patch] unexport sys_{open,read}, Rene Herman, (Mon Sep 10, 6:15 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 6:41 pm)
Re: [-mm patch] unexport sys_{open,read}, Rene Herman, (Mon Sep 10, 6:56 pm)
Re: [-mm patch] unexport sys_{open,read}, Alan Cox, (Mon Sep 10, 1:44 pm)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 1:54 pm)
Re: [-mm patch] unexport sys_{open,read}, Greg KH, (Thu Sep 13, 7:23 pm)
Re: [-mm patch] unexport sys_{open,read}, Alan Cox, (Mon Sep 10, 8:31 am)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 8:03 am)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Sun Sep 9, 6:22 pm)
Re: [-mm patch] unexport sys_{open,read}, Arjan van de Ven, (Sun Sep 9, 6:41 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Sun Sep 9, 7:18 pm)