Re: [PATCH 16/22] advansys: Eliminate prototypes

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matthew Wilcox <matthew@...>
Cc: <linux-scsi@...>, Linux Kernel Mailing List <linux-kernel@...>
Date: Sunday, September 9, 2007 - 11:29 am

Matthew Wilcox wrote:

What thoughts, if any, have been given to post-patch code arrangement, 
besides eliminating prototypes?

This always struck me as a counterproductive exercise when taken by 
itself.  Sure, prototypes were eliminated, but was code packed together 
in an efficient way afterwards?  Ideally hot path code should be close 
together, ditto for various other things like error handling code.

Without further explanation or details about your post-patch analysis, 
how do we even know the new code arrangement doesn't negatively impact 
i-cache overall?

	Jeff


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 16/22] advansys: Eliminate prototypes, Jeff Garzik, (Sun Sep 9, 11:29 am)
Re: [PATCH 16/22] advansys: Eliminate prototypes, Matthew Wilcox, (Sun Sep 9, 1:48 pm)