Home » Mailing list archives » linux-kernel » 2007 » September » 5

use of asm/prom.h

Previous thread: Why do so many machines need "noapic"? by Chuck Ebbert on Wednesday, September 5, 2007 - 7:30 pm. (16 messages)

Next thread: [GIT PULL] m32r: Please pull m32r kernel updates for 2.6.23-rc5 by Hirokazu Takata on Wednesday, September 5, 2007 - 10:45 pm. (1 message)
[view original message]
From: Stephen Rothwell <sfr@...>
To: LKML <linux-kernel@...>
Cc: ppc-dev <linuxppc-dev@...>, <sparclinux@...>, Krzysztof Helt <krzysztof.h1@...>
Subject: use of asm/prom.h
Date: Wednesday, September 5, 2007 - 7:39 pm

Hi all,


I noticed in the ALSA tree:


------------------------------ sound/sparc/dbri.c -------------------------=

-----

index 12d11fc..e96023f 100644

@@ -66,6 +66,7 @@

 #include <sound/control.h>

 #include <sound/initval.h>

=20

+#include <asm/prom.h>

 #include <asm/sbus.h>

 #include <asm/atomic.h>


(I don't mean to pick on this particular example, it is just what was in

front of me.)


Could people please consider using linux/{of,of_device,of_platform}.h

instead of asm/prom.h now that these exist.  Using asm/prom.h only works

now because it includes the above files, but that may (will?) change

eventually.


Most includes of asm/prom.h are there to get access to the routines and

data structures associated with the Open Firmware device tree, and these

are now all available from the above files instead.


--=20

Cheers,

Stephen Rothwell                    sfr@canb.auug.org.au

http://www.canb.auug.org.au/~sfr/
Previous thread: Why do so many machines need "noapic"? by Chuck Ebbert on Wednesday, September 5, 2007 - 7:30 pm. (16 messages)

Next thread: [GIT PULL] m32r: Please pull m32r kernel updates for 2.6.23-rc5 by Hirokazu Takata on Wednesday, September 5, 2007 - 10:45 pm. (1 message)