Re: nfs4 hang regression

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Bret Towe <magnade@...>
Cc: <linux-kernel@...>, <Trond.Myklebust@...>
Date: Wednesday, September 5, 2007 - 11:51 am

> On Wed, 22 Aug 2007 15:41:18 -0700 "Bret Towe" <magnade@gmail.com> wrote:

More than two weeks, you've bisected it and there's no sign of any action?

I don't see this on Michal's list so perhaps it already got fixed in a different
thread.  Have you tested current mainline?


I really wish that hadn't been wordwrapped.

As a random stab-in-the-dark, does this help?

--- a/fs/nfs/nfs4renewd.c~a
+++ a/fs/nfs/nfs4renewd.c
@@ -133,9 +133,7 @@ nfs4_renewd_prepare_shutdown(struct nfs_
 void
 nfs4_kill_renewd(struct nfs_client *clp)
 {
-	down_read(&clp->cl_sem);
 	cancel_delayed_work_sync(&clp->cl_renewd);
-	up_read(&clp->cl_sem);
 }
 
 /*
_

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
nfs4 hang regression, Bret Towe, (Wed Aug 22, 6:41 pm)
Re: nfs4 hang regression, Andrew Morton, (Wed Sep 5, 11:51 am)
Re: nfs4 hang regression, Bret Towe, (Wed Sep 5, 3:47 pm)
Re: nfs4 hang regression, Michal Piotrowski, (Wed Sep 5, 11:56 am)
Re: nfs4 hang regression, Michal Piotrowski, (Wed Sep 5, 12:02 pm)
Re: nfs4 hang regression, Trond Myklebust, (Wed Sep 5, 11:55 am)