Re: [PATCH] slub - Use local_t protection

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Mathieu Desnoyers <mathieu.desnoyers@...>

To: Christoph Lameter <clameter@...>

Cc: Peter Zijlstra <peterz@...>, <akpm@...>, <linux-kernel@...>, <mingo@...>, <linux-ia64@...>

Subject: Re: [PATCH] slub - Use local_t protection

Date: Wednesday, September 5, 2007 - 9:03 am

* Christoph Lameter (clameter@sgi.com) wrote:
quoted text> On Tue, 4 Sep 2007, Mathieu Desnoyers wrote:
> 
> > @@ -1566,12 +1565,13 @@ redo:
> >  		object[c->offset]) != object))
> >  			goto redo;
> >  
> > -	put_cpu();
> > +	local_exit(flags);
> >  	if (unlikely((gfpflags & __GFP_ZERO)))
> >  		memset(object, 0, c->objsize);
> >  
> >  	return object;
> >  slow:
> > +	local_exit(flags);
> 
> Here we can be rescheduled to another processors.
> 
> >  	return __slab_alloc(s, gfpflags, node, addr, c)
> 
> c may point to the wrong processor.

Good point. the current CPU is not updated at the beginning of the
slow path.

I'll post the updated patchset. Comments are welcome, especially about
the naming scheme which is currently awkward.

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 01/23] Fall back on interrupt disable in cmpxchg8b on..., Mathieu Desnoyers, (Mon Aug 20, 4:15 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Christoph Lameter, (Mon Aug 20, 4:32 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Mathieu Desnoyers, (Mon Aug 20, 4:41 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Christoph Lameter, (Mon Aug 20, 4:46 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Mathieu Desnoyers, (Mon Aug 20, 5:29 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Christoph Lameter, (Mon Aug 20, 5:49 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Mathieu Desnoyers, (Mon Aug 20, 5:54 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Christoph Lameter, (Mon Aug 20, 6:07 pm)

[PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 1:38 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 7:14 pm)

Re: [PATCH] SLUB use cmpxchg_local, Peter Zijlstra, (Mon Aug 27, 2:52 am)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 3:39 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 6:15 pm)

Re: [PATCH] SLUB use cmpxchg_local, Peter Zijlstra, (Tue Aug 28, 3:12 am)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 28, 3:36 pm)

Re: [PATCH] SLUB use cmpxchg_local, Peter Zijlstra, (Tue Aug 28, 3:46 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Mon Aug 27, 4:22 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 4:26 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Mon Aug 27, 4:39 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 5:04 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Mon Aug 27, 5:10 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 5:23 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Mon Aug 27, 5:38 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 6:12 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Mon Aug 27, 6:27 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 9:26 pm)

[PATCH] slub - Use local_t protection, Mathieu Desnoyers, (Tue Sep 4, 4:04 pm)

Re: [PATCH] slub - Use local_t protection, Christoph Lameter, (Tue Sep 4, 4:45 pm)

Re: [PATCH] slub - Use local_t protection, Mathieu Desnoyers, (Wed Sep 5, 9:06 am)

Re: [PATCH] slub - Use local_t protection, Christoph Lameter, (Wed Sep 12, 6:28 pm)

[PATCH] local_t protection (critical section), Mathieu Desnoyers, (Wed Sep 5, 9:04 am)

Re: [PATCH] local_t protection (critical section), Christoph Lameter, (Wed Sep 12, 6:33 pm)

Re: [PATCH] local_t protection (critical section), Mathieu Desnoyers, (Wed Sep 12, 7:00 pm)

Re: [PATCH] slub - Use local_t protection, Mathieu Desnoyers, (Wed Sep 5, 9:03 am)

[PATCH] local_t protection (critical section), Mathieu Desnoyers, (Tue Sep 4, 4:03 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Sep 4, 4:02 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 28, 8:07 am)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 28, 3:42 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Mon Aug 27, 6:29 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 7:23 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 7:50 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 5:08 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 7:12 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 7:17 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 7:39 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 7:41 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 7:47 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 7:51 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 8:03 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 8:11 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 8:26 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 8:34 pm)

[PATCH] SLUB: use have_arch_cmpxchg(), Mathieu Desnoyers, (Wed Aug 22, 11:02 am)

Re: [PATCH] SLUB: use have_arch_cmpxchg(), Pekka Enberg, (Wed Aug 22, 12:24 pm)

Re: [PATCH] SLUB: use have_arch_cmpxchg(), Mathieu Desnoyers, (Mon Aug 27, 10:56 am)

Re: [PATCH] SLUB: use have_arch_cmpxchg(), Christoph Lameter, (Mon Aug 27, 3:43 pm)

Re: [PATCH] SLUB: use have_arch_cmpxchg(), Mathieu Desnoyers, (Mon Aug 27, 4:25 pm)

[PATCH] define have_arch_cmpxchg(), Mathieu Desnoyers, (Wed Aug 22, 11:00 am)

Re: [PATCH] define have_arch_cmpxchg(), Christoph Lameter, (Wed Aug 22, 2:50 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 9:18 pm)

Re: [PATCH] SLUB use cmpxchg_local, Andi Kleen, (Tue Aug 21, 9:28 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 8:38 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 9:06 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Wed Aug 22, 9:45 am)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Wed Aug 22, 3:25 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Wed Aug 22, 4:09 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Wed Aug 22, 4:19 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Wed Aug 22, 4:29 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Wed Aug 22, 4:38 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Wed Aug 22, 4:33 pm)

Re: [PATCH] SLUB use cmpxchg_local, Andi Kleen, (Wed Aug 22, 9:46 am)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Wed Aug 22, 2:54 pm)

Re: [PATCH] SLUB use cmpxchg_local, Andi Kleen, (Wed Aug 22, 5:39 am)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 9:12 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 4:41 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 5:36 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 1:44 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 5:10 pm)

Re: [PATCH] SLUB use cmpxchg_local, Mathieu Desnoyers, (Tue Aug 21, 7:21 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 7:38 pm)

Re: [PATCH] SLUB use cmpxchg_local, Christoph Lameter, (Tue Aug 21, 7:35 pm)

Re: [patch 01/23] Fall back on interrupt disable in cmpxchg8..., Mathieu Desnoyers, (Mon Aug 20, 6:29 pm)

[PATCH] SLUB Use cmpxchg() everywhere, Mathieu Desnoyers, (Tue Aug 21, 1:38 pm)

Navigation

Popular discussions


linux-kernel:
Andrew Morton	-mm merge plans for 2.6.23
Greg Kroah-Hartman	[PATCH 025/196] paride: Convert from class_device to device for block/paride
Renato S. Yamane	Error -71 on device descriptor read/all
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:
David Miller	Re: [GIT]: Networking
Gerrit Renker	[PATCH 31/37] dccp: Remove manual influence on NDP Count feature
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Online users

Syndicate