Home » Mailing list archives » linux-kernel » 2007 » September » 4

[PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff Norden <jeff@...>
To: <alan@...>
Cc: <linux-kernel@...>
Subject: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
Date: Tuesday, September 4, 2007 - 12:07 pm

From: Jeff Norden <jnorden@math.tntech.edu>

Fix "lost" interrupt problem when using dma with CD/DVD drives in some
configurations.  This problem can make installing linux from media
impossible for distro's that have switched to libata-only configurations.

The simple fix is to eliminate the use of dma for reading drive status, etc,
by checking the number of bytes to transferred.

This change will only affect the behavior of atapi devices, not disks.
There is more info at http://bugzilla.redhat.com/show_bug.cgi?id=242229
This patch is for 2.6.22.1

Signed-off-by: Jeff Norden <jnorden@math.tntech.edu>

---

--- pata_it821x.c.orig	2007-08-16 14:20:49.000000000 -0500
+++ pata_it821x.c	2007-08-31 16:09:22.000000000 -0500
@@ -533,6 +533,10 @@ static int it821x_check_atapi_dma(struct
 	struct ata_port *ap = qc->ap;
 	struct it821x_dev *itdev = ap->private_data;
 
+	/* Only use dma for transfers to/from the media. */
+	if (qc->nbytes < 2048)
+		return -EOPNOTSUPP;
+
 	/* No ATAPI DMA in smart mode */
 	if (itdev->smart)
 		return -EOPNOTSUPP;

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices, Jeff Norden, (Tue Sep 4, 12:07 pm)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Jeff Garzik, (Mon Sep 10, 9:53 pm)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Mikael Pettersson, (Tue Sep 4, 2:43 pm)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Alan Cox, (Wed Sep 5, 8:39 pm)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Tejun Heo, (Mon Sep 17, 1:00 am)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Alan Cox, (Tue Sep 18, 5:07 am)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Jeff Garzik, (Mon Sep 17, 6:00 am)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Tejun Heo, (Mon Sep 17, 7:46 am)
Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi d..., Alan Cox, (Tue Sep 18, 5:14 am)