Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Christoph Hellwig <hch@...>, Grant Likely <grant.likely@...>, <linux-kernel@...>, <linuxppc-dev@...>, <paulus@...>, <axboe@...>

Subject: Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

Date: Sunday, September 30, 2007 - 7:33 pm

On 9/30/07, Christoph Hellwig <hch@infradead.org> wrote:
quoted text> On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote:
> > +     if ((rc = platform_driver_register(&ace_platform_driver)) != 0)
> > +             goto err_plat;
>
>         rc = platform_driver_register(&ace_platform_driver);
>         if (rc)
>                  goto err_plat;
>
> please.

Okay, will do.

quoted text>
> > +      err_plat:
> > +     unregister_blkdev(ace_major, "xsysace");
> > +      err_blk:
>
> labels should be indented zero or one space, but not more.

scripts/Lindent does this.  Originally, I *didn't* have my labels
indented.  :-)   Does Lindent need to be fixed?

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH v2 0/6] SystemACE: rework and of_platform bus binding..., Grant Likely, (Sun Sep 30, 6:56 pm)

[PATCH v2 2/6] Sysace: Use the established platform bus api, Grant Likely, (Sun Sep 30, 6:57 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bus ..., Christoph Hellwig, (Sun Sep 30, 7:05 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bus ..., Grant Likely, (Sun Sep 30, 7:33 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bus ..., Jens Axboe, (Mon Oct 1, 7:59 am)

Re: [PATCH v2 2/6] Sysace: Use the established platform bus ..., Benjamin Herrenschmidt, (Tue Oct 2, 1:58 am)

Re: [PATCH v2 2/6] Sysace: Use the established platform bus ..., Jens Axboe, (Tue Oct 2, 2:35 am)

Re: [PATCH v2 2/6] Sysace: Use the established platform bus ..., Grant Likely, (Tue Oct 2, 9:52 am)

Re: [PATCH v2 2/6] Sysace: Use the established platform bus ..., Grant Likely, (Mon Oct 1, 9:17 am)

[PATCH v2 1/6] Add Xilinx SystemACE entry to maintainers, Grant Likely, (Sun Sep 30, 6:57 pm)

[PATCH v2 4/6] Sysace: minor rework and cleanup changes, Grant Likely, (Sun Sep 30, 6:57 pm)

[PATCH v2 5/6] Sysace: Move IRQ handler registration to occu..., Grant Likely, (Sun Sep 30, 6:57 pm)

Re: [PATCH v2 5/6] Sysace: Move IRQ handler registration to ..., Benjamin Herrenschmidt, (Tue Oct 2, 1:55 am)

Re: [PATCH v2 5/6] Sysace: Move IRQ handler registration to ..., Grant Likely, (Tue Oct 2, 9:57 am)

[PATCH v2 6/6] Sysace: Add of_platform_bus binding, Grant Likely, (Sun Sep 30, 6:57 pm)

[PATCH v2 3/6] Sysace: Move structure allocation from bus bi..., Grant Likely, (Sun Sep 30, 6:57 pm)


linux-kernel:
Glauber de Oliveira Costa	[PATCH 08/79] [PATCH] use identify_boot_cpu
David Woodhouse	[PATCH v2] Stop pmac_zilog from abusing 8250's device numbers.
Greg Kroah-Hartman	[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Jeremy Fitzhardinge	[PATCH 30 of 31] xen: no need for domU to worry about MCE/MCA
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

Online users