RFC: [PATCH] Small patch on top of per device dirty throttling -v9

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Peter Zijlstra <a.p.zijlstra@...>, <spamtrap@...>
Cc: <linux-kernel@...>
Date: Monday, September 3, 2007 - 11:20 am

--- Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

Hi Peter,

 while doing my tests I observed that setting dirty_ratio below 5% did
not make a difference at all. Just by chance I found that this
apparently is an enforced limit in mm/page-writeback.c.

 With below patch I have lowered the limit to 2%. With that, things
look a lot better on my systems. Load during write stays below 1.5 for
one writer. Responsiveness is good. 

This may even help without the throttling patch. Not sure that this is
the right thing to do, but it helps :-)

Cheers
Martin

--- linux-2.6.22.5-bdi-v9/mm/page-writeback.c
+++ linux-2.6.22.6+bdi-v9/mm/page-writeback.c
@@ -311,8 +311,11 @@
        if (dirty_ratio > unmapped_ratio / 2)
                dirty_ratio = unmapped_ratio / 2;

-       if (dirty_ratio < 5)
-               dirty_ratio = 5;
+/*
+** MKN: Lower enforced limit from 5% to 2%
+*/
+       if (dirty_ratio < 2)
+               dirty_ratio = 2;

        background_ratio = dirty_background_ratio;
        if (background_ratio >= dirty_ratio)


------------------------------------------------------
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RE: [PATCH 00/23] per device dirty throttling -v9, Martin Knoblauch, (Thu Aug 16, 8:49 am)
RE: [PATCH 00/23] per device dirty throttling -v9, Peter Zijlstra, (Thu Aug 16, 8:55 am)
RE: [PATCH 00/23] per device dirty throttling -v9, Martin Knoblauch, (Thu Aug 23, 11:59 am)
RE: [PATCH 00/23] per device dirty throttling -v9, Peter Zijlstra, (Thu Aug 23, 1:41 pm)
RFC: [PATCH] Small patch on top of per device dirty throttli..., Martin Knoblauch, (Mon Sep 3, 11:20 am)
RE: [PATCH 00/23] per device dirty throttling -v9, Martin Knoblauch, (Fri Aug 24, 6:47 am)
RE: [PATCH 00/23] per device dirty throttling -v9, Martin Knoblauch, (Thu Aug 16, 9:21 am)