[PATCH 19/32] Unionfs: partial_lookup update

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Josef 'Jeff' Sipek
Date: Sunday, September 2, 2007 - 7:20 pm

From: Erez Zadok <ezk@cs.sunysb.edu>

Handle new semantics of lookup_backend.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
---
 fs/unionfs/lookup.c |   22 ++++++++++++++++------
 1 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c
index e4e8470..d05daa5 100644
--- a/fs/unionfs/lookup.c
+++ b/fs/unionfs/lookup.c
@@ -425,20 +425,30 @@ out:
 	return ERR_PTR(err);
 }
 
-/* This is a utility function that fills in a unionfs dentry */
+/*
+ * This is a utility function that fills in a unionfs dentry.
+ *
+ * Returns: 0 (ok), or -ERRNO if an error occurred.
+ */
 int unionfs_partial_lookup(struct dentry *dentry)
 {
 	struct dentry *tmp;
 	struct nameidata nd = { .flags = 0 };
+	int err = -ENOSYS;
 
 	tmp = unionfs_lookup_backend(dentry, &nd, INTERPOSE_PARTIAL);
-	if (!tmp)
-		return 0;
-	if (IS_ERR(tmp))
-		return PTR_ERR(tmp);
+	if (!tmp) {
+		err = 0;
+		goto out;
+	}
+	if (IS_ERR(tmp)) {
+		err = PTR_ERR(tmp);
+		goto out;
+	}
 	/* need to change the interface */
 	BUG_ON(tmp != dentry);
-	return -ENOSYS;
+out:
+	return err;
 }
 
 /* The dentry cache is just so we have properly sized dentries. */
-- 
1.5.2.2.238.g7cbf2f2

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 01/32] VFS: export release_open_intent symbol, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 02/32] VFS/fsstack: remove 3rd argument to fsstack_ ..., Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 03/32] VFS/fsstack: cpp endif comments, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 04/32] Unionfs: fixed compilation error, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 05/32] Unionfs: do not use fsstack_copy_attr_all, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 06/32] Unionfs: copyright corrections and updates, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 07/32] Unionfs: cpp endif comments, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 08/32] Unionfs: cache-coherency - update inode times, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 09/32] Unionfs: cache-coherency - dentries, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 10/32] Unionfs: cache-coherency - file flush, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 11/32] Unionfs: cache-coherency and fixes for union ..., Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 12/32] Unionfs: documentation updates, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 13/32] Unionfs: copyup updates, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 14/32] Unionfs: file_revalidate updates, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 15/32] Unionfs: implement f/async, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 16/32] Unionfs: minor file_release updates, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 17/32] Unionfs: interpose updates, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 18/32] Unionfs: unionfs_ioctl bug fixes, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 19/32] Unionfs: partial_lookup update, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 20/32] Unionfs: lower nameidata support, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 21/32] Unionfs: mmap fixes, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 22/32] Unionfs: handling lower vfsmount fixes, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 23/32] Unionfs: mount-time option parsing fix, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 24/32] Unionfs: remove old nfsro option, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 25/32] Unionfs: readonly branch test fix, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 26/32] Unionfs: minor remount fixes, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 27/32] Unionfs: extended attributes fixes, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 28/32] Unionfs: use file f_path field, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 29/32] Unionfs: assorted comment and style updates, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 30/32] Unionfs: update unionfs version number, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 31/32] Unionfs: debugging and validation of fan-out ..., Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
[PATCH 32/32] Unionfs: unionfs_create rewrite, Josef 'Jeff' Sipek, (Sun Sep 2, 7:20 pm)
Re: [PATCH 03/32] VFS/fsstack: cpp endif comments, Jan Engelhardt, (Sun Sep 2, 11:39 pm)
Re: [PATCH 09/32] Unionfs: cache-coherency - dentries, Jan Engelhardt, (Sun Sep 2, 11:52 pm)
Re: [PATCH 12/32] Unionfs: documentation updates, Jan Engelhardt, (Sun Sep 2, 11:59 pm)
Re: [PATCH 12/32] Unionfs: documentation updates, Josef 'Jeff' Sipek, (Mon Sep 3, 7:04 am)
Re: [PATCH 09/32] Unionfs: cache-coherency - dentries, Josef 'Jeff' Sipek, (Mon Sep 3, 7:08 am)
Re: [PATCH 09/32] Unionfs: cache-coherency - dentries, Jan Engelhardt, (Mon Sep 3, 7:23 am)
Re: [PATCH 01/32] VFS: export release_open_intent symbol, Josef 'Jeff' Sipek, (Mon Sep 3, 10:38 am)
[PATCH 1/1] Unionfs: cache-coherency - dentries, Josef 'Jeff' Sipek, (Mon Sep 3, 4:39 pm)
Re: [PATCH 03/32] VFS/fsstack: cpp endif comments, Josef 'Jeff' Sipek, (Mon Sep 3, 4:43 pm)
Re: [PATCH 1/1] Unionfs: cache-coherency - dentries, Josef 'Jeff' Sipek, (Thu Sep 6, 9:43 am)
[PATCH 1/1] Unionfs: cache-coherency - dentries, Josef 'Jeff' Sipek, (Thu Sep 6, 9:45 am)