linux-kernel mailing list

FromSubjectsort iconDate
Nick Piggin
Re: [PATCH] cpuset and sched domains: sched_load_balance flag
I don't like adding these funny special case sort of things like this. The user should just be able to specify exactly the partitioning of tasks required, and cpusets should ask the scheduler to do the best job of load balancing possible. I implemented that with my patches to do automatic discovery of the largest set of disjoint cpusets. From there, the problem that cpusets has, is that it lacks a good way to specify that the machine should be partitioned (IIRC because stuff defaults to going ...
Sep 29, 3:21 pm 2007
Nick Piggin
Re: [PATCH] cpuset and sched domains: sched_load_balance flag
But you could do that just by having the current cpuset scheme able to properly partition the system. You can't (easily) do this now because you have so many tasks in the root cpuset that it is impossible to know whether or not you actually want to load balance them. You would do this by creating partitioning cpusets which carve up the In this case the admin would simply not partition the system (they would retain a single root cpuset). Neither approach is really fundamentally more or less po...
Sep 29, 11:34 pm 2007
Rob Landley
[PATCH] Add Documentation/{w1,w1/masters}/00-INDEX
From: Rob Landley <rob@landley.net> Two 00-INDEX files under Documentation/w1 Signed-off-by: Rob Landley <rob@landley.net> --- Documentation/w1/00-INDEX | 8 ++++++++ Documentation/w1/masters/00-INDEX | 6 ++++++ 2 files changed, 14 insertions(+) --- /dev/null 2007-04-23 10:59:00.000000000 -0500 +++ kdocs/Documentation/w1/00-INDEX 2007-09-29 13:24:40.000000000 -0500 @@ -0,0 +1,8 @@ +00-INDEX + - This file +masters/ + - Individual chips providing 1-wire busses....
Sep 29, 11:21 pm 2007
Rob Landley
[PATCH] Add missing entries to top level Documentation/00-IN...
From: Rob Landley <rob@landley.net> Add missing entries to Documentation/00-INDEX Signed-off-by: Rob Landley <rob@landley.net> --- Documentation/00-INDEX | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff -r dc28e4e17791 Documentation/00-INDEX --- a/Documentation/00-INDEX Wed Sep 26 15:52:17 2007 -0700 +++ b/Documentation/00-INDEX Sat Sep 29 14:07:39 2007 -0500 @@ -22,6 +21,8 @@ CodingStyle - how the boss likes the C code in the kernel to look. ...
Sep 29, 11:19 pm 2007
Rob Landley
[PATCH] Tweak Documentation/SM501.txt
From: Rob Landley <rob@landley.net> The existing Documentation/SM501.txt gives no clue what the chip is or does, so copy the description from Kconfig help text. cc: Ben Dooks <ben@simtec.co.uk> Signed-off-by: Rob Landley <rob@landley.net> --- Documentation/SM501.txt | 5 +++++ 1 file changed, 5 insertions(+) diff -r dc28e4e17791 Documentation/SM501.txt --- a/Documentation/SM501.txt Wed Sep 26 15:52:17 2007 -0700 +++ b/Documentation/SM501.txt Sat Sep 29 14:01:43 2007...
Sep 29, 11:15 pm 2007
Dave Young
bluetooth: hci_sysfs work queue problem
Hi, The hci_sysfs uses work queue to finish the sysfs add/del fuction. But when the same device connection failed, if another connection of same device come in before the delete work finish, sysfs will warn about duplicate filename creating. Sep 19 12:30:27 darkstar kernel: sysfs: duplicate filename 'acl00194FDB6C71' can not be created Sep 19 12:30:27 darkstar kernel: WARNING: at fs/sysfs/dir.c:433 sysfs_add_one() Sep 19 12:30:27 darkstar kernel: [<c01c3ad0>] sysfs_add_one+0xa0/0xe0 Sep 19...
Sep 29, 9:46 pm 2007
Casey Schaufler
[PATCH] Version 3 (2.6.23-rc8) Smack: Simplified Mandatory A...
From: Casey Schaufler <casey@schaufler-ca.com> Smack is the Simplified Mandatory Access Control Kernel. Smack implements mandatory access control (MAC) using labels attached to tasks and data containers, including files, SVIPC, and other tasks. Smack is a kernel based scheme that requires an absolute minimum of application support and a very small amount of configuration data. Smack is implemented as a clean LSM. It requires no external code changes and the patch modifies only the Kcon...
Sep 29, 8:20 pm 2007
Måns Rullgård
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
Would also add rules like "don't put parens around the word device" etc? There are countless silly things one could do, and we can't explicitly prohibit all of them. -- Måns Rullgård mans@mansr.com -
Sep 29, 6:55 pm 2007
Sam Ravnborg
[RFC] Extending kbuild syntax
Over the last few weeks I have pondered with the idea to extend the current kbuild syntax. The idea have existed for long but only recently I started to think how to do this in a truely flexible manner. Two areas are in need for a bit of attention to improve current kbuild files in the kernel. The first issue is the EXTRA_CFLAGS. They are often conditionally assigned like in the following example: ifeq ($(DEBUG),y) EXTRA_CFLAGS := -DDEBUG endif Introducing the following new variable coul...
Sep 29, 4:11 pm 2007
Adrian Bunk
Re: [RFC] Extending kbuild syntax
IMHO for people who are not kbuild junkies the pattern is more clear with the current syntax. But you should better ask some guinea pigs who have not already seen as Some of the cases have the following pattern: config X86_POWERNOW_K8_ACPI bool depends on X86_POWERNOW_K8 && ACPI_PROCESSOR depends on !(X86_POWERNOW_K8 = y && ACPI_PROCESSOR = m) default y Your suggested syntax has to be enhanced with three additional variables for handling ...
Sep 29, 11:02 pm 2007
Sergei Shtylyov
[PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)
The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for this -- to achieve this: - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz with his consent, also adding the method callout to ide_rate_filter(); - install the method for all chips to only return empty mask if a SATA drive is detected on HPT372{AN]/374 chips... Signed-off-by:...
Sep 29, 4:04 pm 2007
Andrew Morton
Re: [2.6.23-rc8-mm2] System hangs (loops?) during boot
Great, thanks for doing that. I guess I'll drop the patch for now in that case. -
Sep 29, 4:02 pm 2007
Bill Davidsen
[FYI] 2.6.23-rc8-git3 misc observations
Running FC6 (updated this am) the temp sensors GNOME applet works with the kernel.org kernel, not the FC6 kernel. This has been true for a while, and I've stopped chasing it, I don't really care right now, since the sensors command works fine and that's what my daemon checks. Using 2.6.23-rc8 (no git) the NIC came up at 100Mbit instead of gigE once, not reproducible. Just in case this kicks off a bunch of "mee too" replies. lspci info follows text. Boot times: I occasionally boot repeatedly ...
Sep 29, 3:48 pm 2007
Schmidt, Kenneth P
FW: [patch 01/02] vfs: variant symlinks
Several networked filesystems (i.e. afs) have similar concepts. This just moves it into the vfs layer so that it can be used on all of them and even local filesystems. The best example of how this can be useful is to allow a heterogeneous environment which uses a common filesystem. For example, both x86_64 and power systems could mount a root nfs share and execute with a common set of configurations and data, but the binary directories (bin and lib) could point to architecture specific direc...
Sep 29, 3:40 pm 2007
Trond Myklebust
Re: FW: [patch 01/02] vfs: variant symlinks
That would hardly be a portable NFS environment. Boot a Solaris, or older Linux kernel, and watch your applications barf... This sort of stuff belongs in the automounter, not the kernel. Trond -
Sep 29, 5:59 pm 2007
Al Viro
Re: FW: [patch 01/02] vfs: variant symlinks
mount --bind /usr/$(ARCH)/bin /usr/bin mount --bind /usr/$(ARCH)/lib /usr/lib or corresponding ones in /etc/fstab. BFD... -
Sep 29, 4:33 pm 2007
Justin Piszcz Sep 29, 2:37 pm 2007
Bill Davidsen
2.6.23-rc8 - Hangcheck on resume from x2mem
I find this in dmesg after resume from s2mem: Hangcheck: hangcheck value past margin! System: ASUS P5LD2-VM board, Intel 6600 CPU at 2.40 GHz (no o/c) 2GB RAM, 3x320GB SATA sw RAID-5. FC6 distribution, fully updated, suspend via "system" menu pulldown. Just in case this is of interest, the resume and suspend work without suspend2 patching, although since it's a server and has mains power it's only of interest for testing. USB backup devices were *not* connected. -- Bill Davidsen...
Sep 29, 1:54 pm 2007
Jan Luebbe
[PATCH] fix console change race exposed by CFS
From: Jan Lübbe <jluebbe@lasnet.de> The new behaviour of CFS exposes a race which occurs if a switch is requested when vt_mode.mode is VT_PROCESS. The process with vc->vt_pid is signaled before vc->vt_newvt is set. This causes the switch to fail when triggered by the monitoing process because the target is still -1. Signed-off-by: Jan Lübbe <jluebbe@lasnet.de> --- Index: linux-2.6.22/drivers/char/vt_ioctl.c ==================================================================...
Sep 29, 12:47 pm 2007
Justin Piszcz
Bonnie++ with 1024k stripe SW/RAID5 causes kernel to goto D-...
Kernel: 2.6.23-rc8 (older kernels do this as well) When running the following command: /usr/bin/time /usr/sbin/bonnie++ -d /x/test -s 16384 -m p34 -n 16:100000:16:64 It hangs unless I increase various parameters md/raid such as the stripe_cache_size etc.. # ps auxww | grep D USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND root 276 0.0 0.0 0 0 ? D 12:14 0:00 [pdflush] root 277 0.0 0.0 0 0 ? D 12:14 0:00 [pdflush...
Sep 29, 1:08 pm 2007
Chris Snook
Re: Bonnie++ with 1024k stripe SW/RAID5 causes kernel to got...
Not at all. 1024k stripes are way outside the norm. If you do something way outside the norm, and don't tune for it in advance, don't be terribly surprised when something like bonnie++ brings your box to its knees. That's not to say we couldn't make md auto-tune itself more intelligently, but this isn't really a bug. With a sufficiently huge amount of RAM, you'd be able to dynamically allocate the buffers that you're not pre-allocating with stripe_cache_size, but bonnie++ is eating that up...
Sep 29, 2:33 pm 2007
Florian Schmidt
getting FUSD compiled with current kernels
Hi, I'm trying to build FUSD [1] against current kernels [2.6.22]. I get errors [2]: I tried looking into it but not being a kernel hacker i must admit i didn't even find out where sysfs_dentry is defined (so i can make the type complete). Or whether this would even be the correct way to fix it.. My goal is to hack up oss2jack [3] to use ALSA pcm devices.. And a later goal is to create a virtual ALSA soundcard [which would multiplex access to a real non hw-mixing capable soundcard] to f...
Sep 29, 12:23 pm 2007
Lee Revell
Re: getting FUSD compiled with current kernels
What problems with ALSA's userspace mixing are you trying to solve? Lee -
Sep 29, 9:26 pm 2007
Florian Schmidt
Re: getting FUSD compiled with current kernels
Oh i forgot to show the code snippets in question. I put them to the static inline struct kobject * to_kobj(struct dentry * dentry) { struct sysfs_dirent * sd = dentry->d_fsdata; if(sd) return ((struct kobject *) sd->s_element); [*] else return NULL; [...] if(classdir2){ // jackpot. extract the class. struct kobject *ko = to_kobj(classdir2); sys_class = (ko?to_class(ko):NULL); [*] if(!sys_class) ...
Sep 29, 12:35 pm 2007
Florian Schmidt
Re: getting FUSD compiled with current kernels
Oh and i also forget to mention that i get the same errors when using: KDIR=/usr/src/linux-source-2.6.22/ make [Where the ubuntu kernel package put the source. I configured it with the default ubuntu .config and make oldconfig]. I get one more message though: ~/source/build_stuff/fusd/kfusd$ KDIR=/usr/src/linux-source-2.6.22/ make make -C /usr/src/linux-source-2.6.22/ SUBDIRS=/home/tapas/source/build_stuff/fusd/kfusd EXTRA_CFLAGS=-I/home/tapas/source/build_stuff/fusd/kfusd/../include modul...
Sep 29, 12:37 pm 2007
Sam Ravnborg
Re: getting FUSD compiled with current kernels
This is because you build using a kernel with a non-complete build. Maybe ubuntu locate output files somewhere else? If thats the case use: export KBUILD_OUTPUT=dir make to tell kbuild where to find the output files for the kernel source. Sam -
Sep 29, 1:16 pm 2007
David Newall
Chroot bug take 3
/. I hope I haven't crossed the line between determined and annoying. I thought we were done, but now I find meat still on this bone. Posit a normal process having some filesystem root, and a current working directory (pwd) lying within that root subtree. When chroot is performed, pwd is left unchanged. This means it can (and often will) lie outside of the new root. How much of the filesystem lying outside of root should a process be allowed to access? Currently it is the complete fil...
Sep 29, 11:21 am 2007
Carl-Daniel Hailfinger
IT8716F SPI driver submission?
Hi! I have written a rough code skeleton to be able to use the ITE IT8716F Super I/O chip as SPI host/master. The code works fine in userspace, but the Linux kernel SPI framework looks like it could save me from implementing full support for SPI flash clients/slaves. That's why I'd like to rewrite my code in a manner that's suitable for kernel inclusion. The IT8716F accepts commands byte-wise and does all of the lifting on the SPI bus as well. There are limitations, though: - It can send 1,2,4,5...
Sep 29, 9:45 am 2007
David Brownell
Re: [spi-devel-general] IT8716F SPI driver submission?
None that I know of. You might find it's easier to just work with a bastardized version of the (latest, with the 2.6.24 MTD updates so it handleds even more chips) m25p80 driver and not go through the SPI framework. It doesn't look like you could even bitbang SPI there, since not all those pins are usable for bit-level I/O. As you note, that hardware doesn't support all that a SPI controller does. It's provided for accessing a single serial flash chip; and not even to do that very smoothly. Y...
Sep 29, 4:39 pm 2007
Nick Piggin
[rfc][patch] i386: remove comment about barriers
Hi, OK this was going to be a quick patch, but after sleeping on it, I think it deserves a better analysis... I can prove the comment is incorrect with a test program, but I'm not as sure about my thinking that leads me to call it also misleading. The comment being removed by this patch is incorrect and misleading (I think). 1. load ... 2. store 1 -> X 3. wmb 4. rmb 5. load a <- Y 6. store ... 4 will only ensure ordering of 1 with 5. 3 will only ensure ordering of 2 with 6. ...
Sep 29, 9:28 am 2007
Paul E. McKenney
Re: [rfc][patch] i386: remove comment about barriers
Yes, because x86 allows loads to be executed before earlier stores, Anyone that does expect this needs to adjust their expectations. ;-) -
Sep 29, 11:16 pm 2007
Davide Libenzi
Re: [rfc][patch] i386: remove comment about barriers
No, that can't be. rmb+wmb can't be considered a full mb. There was a recent discussion about this in the thread originated by peterz scalable rw_mutex patches. - Davide -
Sep 29, 3:12 pm 2007
Linus Torvalds
Re: [rfc][patch] i386: remove comment about barriers
You're 100% right, that comment is total crap. An lfence is *not* a memory barrier, it's just a read memory barrier. Although on some microarchitectures they may of course end up being the same thing. Linus -
Sep 29, 12:11 pm 2007
FUJITA Tomonori
[PATCH -mm] intel-iommu sg chaining support
x86_64 defines ARCH_HAS_SG_CHAIN. So if IOMMU implementations don't support sg chaining, we will get data corruption. Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> --- drivers/pci/intel-iommu.c | 32 ++++++++++++++++---------------- 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index dab329f..4668995 100644 --- a/drivers/pci/intel-iommu.c +++ b/drivers/pci/intel-iommu.c @@ -1963,7 +1963,7 @@ stati...
Sep 29, 8:16 am 2007
Matthew
Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v...
Hi Ingo & everbody on the list, first of all: many thanks for developing this great scheduler (also: kudos to Con Kolivas for having developed SD & CK-patchset) (this is my second mail to this list and I hope I'm doing everything right) I'm doing some backup during work right now: rsyncing my home partition (nearly 180 GB) to another harddrive locally & since I'm running compiz-fusion, openoffice and gnome, therefore am in some real "working environment" I thought: give Ingo's new ...
Sep 29, 7:11 am 2007
Jean Delvare
[PATCH] CodingStyle: Printing numbers in parentheses is fine
Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases it makes the message easier to read. As a matter of fact, this practice is widely used in the kernel: linux-2.6.23-rc8$ quilt grep -I '(%l*[du])' | wc -l 3166 linux-2.6.23-rc8$ Signed-off-by: Jean Delvare <khali@linux-fr.org> --- Documentation/CodingStyle | 2 -- 1 file changed, 2 deletions(-) --- linux-2.6.23-rc8.orig/Documentation/Codi...
Sep 29, 6:25 am 2007
Andrew Morton
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
I wonder how that got there. Printing something like bytes remaining: 0x12 (18) is a quite logical thing to do, although pretty darm pointless. otoh, looking at the various instances, we have lots of stuff like this: printk(KERN_ERR "seq-oss: unable to delete queue %d (%d)\n", queue, rc); which I would argue is wrong and is inconsistent with most other error reporting. It should be unable to delete queue %d: %d And this: printk(KERN_ERR "%s: context size (%u) exc...
Sep 29, 6:51 am 2007
Valdis.Kletnieks
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
On the other hand, printing this: magic number: 0x2710 probably doesn't ring any bells, but if you changed that format to be "magic number: %x (%d)",foo,foo you'll almost certainly sit up and ask "Where the fsck did *that* come from?" (unless you're a *lot* better at doing hex conversions in your head than I). Yeah, *usually* pointless, but it has its place sometimes....
Sep 29, 10:18 pm 2007
Randy Dunlap Sep 29, 2:29 pm 2007
David Brownell
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
But ... why? What value could needless parens provide? "Yet Another Subtle And Hard To Fix Source Of Bloat" is not a plus. I'd kind of think a change like this should have some positive motivation. -
Sep 29, 2:53 pm 2007
Randy Dunlap
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
"Me, I agree that numbers in parens don't usually make sense for kernel messages." It's too trivial to be included in CodingStyle. --- ~Randy -
Sep 29, 4:13 pm 2007
David Brownell
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
Jean, which is why he submitted the patch. You, implicitly, by acking a patch saying those parens are bad. Evidently not, since removing it would promote such bloat. So the reason to remove that guideline, and thereby encourage proliferation of needless parens, is ... that some OTHER way to get rid of them is working? I would agree that line could be improved to say that messages should not be needlessly large. Excess parens are one example; wordiness is another (including printing 8 bit fi...
Sep 29, 6:30 pm 2007
Randy Dunlap
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
Thanks for clearing that up. Yes, you did have me confused. Sure, if something is needless, it doesn't provide value. Andrew listed some cases where parens make sense. He didn't say (and I don't say) [oops, parens] that they always make sense, but the statement in CodingStyle is too strict. Sometimes they --- ~Randy -
Sep 29, 6:51 pm 2007
David Brownell
Re: [PATCH] CodingStyle: Printing numbers in parentheses is ...
Well, the only place that numbers "naturally" appear wrapped in parenthesis is tables of credits and debits... as a debit, sort of a literal "add no value" situation. ;) Oh, and for footnotes, in typographically challenged contexts. Me, I agree that numbers in parens don't usually make sense for kernel messages. - Dave -
Sep 29, 1:19 pm 2007
Akinobu Mita
[PATCH] update sb->s_frozen when freezing read-only mount...
freeze_bdev() with the device which is mounted as read only does not change sb->s_frozen from SB_UNFROZEN to SB_FREEZE_TRANS. Because of this behavior, xfs_freeze can break read-only XFS filesystem. Because xfs_thaw does nothing for the filesystem whose sb->s_frozen is SB_UNFROZEN. So freezed readonly XFS filesystem will never be unfreezed. Then we cannot do any unmount/remount operations for that filesystem. This patch updates sb->s_frozen when freeze_bdev() is called for read-only mo...
Sep 29, 6:09 am 2007
Akinobu Mita
[PATCH] module: return error when mod_sysfs_init() failed
load_module() returns zero when mod_sysfs_init() fails, then the module loading will succeed accidentally. This patch makes load_module() return error correctly in that case. Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> --- kernel/module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: 2.6-git/kernel/module.c =======================================================...
Sep 29, 6:06 am 2007
Greg KH
Re: [PATCH] module: return error when mod_sysfs_init() failed
I must be still asleep this morning, but I think this patch does the exact same thing as the original code does, right? Otherwise, this code would always be failing. Or do I just need to go get my morning coffee to wake up and see the problem here? thanks, greg k-h -
Sep 29, 10:56 am 2007
Akinobu Mita
Re: [PATCH] module: return error when mod_sysfs_init() failed
Hello, In the original code, the "err" is zero before goto cleanup. This "err" will be the return value of load_module(). load_module() is the function which returns error as pointer and the expression IS_ERR(NULL) is false. So the caller of load_module() cannot catch that error. I found this problem when I was running the fault injection test script in Documentation/fault-injection/fault-injection.txt with random module. #!/bin/bash FAILTYPE=failslab echo Y > /debug/$FAILTYPE/task...
Sep 29, 11:37 am 2007
Greg KH
Re: [PATCH] module: return error when mod_sysfs_init() failed
Ah, ok, that makes sense now, thanks. It was the error not getting returned, it was not the fact that we were incorrectly checking the return value of mod_sysfs_init. thanks for clearing this up. greg k-h -
Sep 29, 1:17 pm 2007
Rusty Russell Sep 29, 9:51 am 2007
previous daytodaynext day
September 28, 2007September 29, 2007September 30, 2007