login
Header Space

 
 

Re: [PATCH 1/3] CodingStyle updates

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Erez Zadok <ezk@...>
Cc: <torvalds@...>, <akpm@...>, <linux-kernel@...>, Kok, Auke <auke-jan.h.kok@...>, Kyle Moffett <mrmacman_g4@...>, Jan Engelhardt <jengelh@...>, Adrian Bunk <bunk@...>, roel <12o3l@...>
Date: Saturday, September 29, 2007 - 11:59 am

A couple of comments interspersed...

On 9/28/07, Erez Zadok <ezk@cs.sunysb.edu> wrote:
...
---

I think this "which" is non-restrictive, so it should have a comma
after it (I realize that's not part of your patch). It's also possible
to read it as restrictive, in which case "that" would be preferable.

---
---

"A number of people often like to..." is awkward. How about
"Developers sometimes..." or "Too many people..."

---

---

You might say "The kernel provides the macros likely()..."

---
...
---

The commas after "passed" and "thread" is unnecessary.

---
---

"...by the time it return." should be "...by the time it returns."

---
---

This "which" is restrictive; it would be preferable to use "that" instead.

---
...
---

The hyphen isn't necessary when the first word of the compount
adjective is an adverb ending in "-ly", so, just "seemingly rare"; or
switch to "apparently rare".

---
...


-- 
scott preece
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] 0/3 coding standards documentation/code updates, Linus Torvalds, (Sat Sep 29, 11:00 pm)
Re: [PATCH] 0/3 coding standards documentation/code updates, Linus Torvalds, (Sat Sep 29, 11:35 pm)
Re: [PATCH] 0/3 coding standards documentation/code updates, Robert P. J. Day, (Sat Sep 29, 5:56 pm)
Re: [PATCH] 0/3 coding standards documentation/code updates, J. Bruce Fields, (Sat Sep 29, 3:56 pm)
[PATCH 1/3] CodingStyle updates, Erez Zadok, (Fri Sep 28, 5:32 pm)
Re: [PATCH 1/3] CodingStyle updates, Randy Dunlap, (Sat Sep 29, 2:01 pm)
Re: [PATCH 1/3] CodingStyle updates, Sam Ravnborg, (Sat Sep 29, 2:29 pm)
Re: [PATCH 1/3] CodingStyle updates, Scott Preece, (Sat Sep 29, 11:59 am)
Re: [PATCH 1/3] CodingStyle updates, Shawn Bohrer, (Sat Sep 29, 10:43 am)
Re: [PATCH 1/3] CodingStyle updates, Randy Dunlap, (Fri Sep 28, 5:46 pm)
[PATCH 2/3] Update usage string for checkpatch.pl, Erez Zadok, (Fri Sep 28, 5:32 pm)
speck-geostationary