login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
September
»
29
Re: [COMPAT] Add compat_merge64 helper
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Heiko Carstens <heiko.carstens@...>
To: Kyle McMartin <kyle@...>
Cc: <linux-arch@...>, <linux-kernel@...>
Subject:
Re: [COMPAT] Add compat_merge64 helper
Date: Saturday, September 29, 2007 - 5:48 am
On Fri, Sep 28, 2007 at 06:33:51PM -0400, Kyle McMartin wrote:
quoted text
> To be used when endianness matters for argument ordering when reassembling > a 64-bit value out of two register halves. > > Signed-off-by: Kyle McMartin <kyle@mcmartin.ca> > > +static inline u64 compat_merge64(u32 left, u32 right) > +{ > +#if defined(__BIG_ENDIAN) > + return ((u64)left << 32) | right; > +#else /* defined (__LITTLE_ENDIAN) */
Could you change that to an #elif please and #error out if none is defined? Should safe us from subtle bugs caused by missing includes. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[COMPAT] Add compat_merge64 helper
, Kyle McMartin
, (Fri Sep 28, 6:33 pm)
Re: [COMPAT] Add compat_merge64 helper
, Heiko Carstens
, (Sat Sep 29, 5:48 am)
Re: [COMPAT] Add compat_merge64 helper
, Ralf Baechle
, (Wed Oct 3, 8:12 am)
Re: [COMPAT] Add compat_merge64 helper
, Arnd Bergmann
, (Fri Sep 28, 7:38 pm)
Re: [COMPAT] Add compat_merge64 helper
, Kyle McMartin
, (Fri Sep 28, 8:01 pm)
Re: [COMPAT] Add compat_merge64 helper
, Arnd Bergmann
, (Fri Sep 28, 7:52 pm)
Re: [COMPAT] Add compat_merge64 helper
, Kyle McMartin
, (Fri Sep 28, 8:02 pm)
Re: [COMPAT] Add compat_merge64 helper
, Paul Mundt
, (Sat Sep 29, 3:23 am)
[PATCH] Generic compat_sys_fallocate
, Kyle McMartin
, (Fri Sep 28, 6:33 pm)
Re: [PATCH] Generic compat_sys_fallocate
, Geert Uytterhoeven
, (Sat Sep 29, 5:11 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
[GIT PATCH] driver core patches against 2.6.24
debian developer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Vu Pham
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Adrian Bunk
Re: Linux 2.6.21
git
:
linux-netdev
:
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Radu Rendec
Endianness problem with u32 classifier hash masks
Benjamin Herrenschmidt
[PATCH 0/11] ibm_newemac: Candidate patches for 2.6.25
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
754 guests
online.
Online users
jraval618
creativewebs279
Syndicate