| From | Subject | Date |
|---|---|---|
| Adam Wysocki | [sdhci] mmc0: unrecognised SCR structure version 1
[CCd to possibly interested Pierre Ossman and Rodolfo Giometti]
Hi there,
First, sorry for my poor english - I am not a native.
I know there have been a thread about this problem few months ago, but as
far as I see it did not led to any results:
http://groups.google.com/group/linux.kernel/browse_thread/thread/19116cafe8a20b5/4a28c...
I have the same problem, as described there, with Kingston 2GB SD card. My
card reader is embedded into Fujitsu-Siemens AMILO Pro V3505 notebook and
...
| Sep 28, 11:42 pm 2007 |
| Jeff Garzik | Re: MSI interrupts and disable_irq
(added linux-kernel to CC, since I think it's more of a general kernel
issue)
To be brutally frank, I always thought this disable_irq() mess was a
hack both ugly and fragile. This disable_irq() work that appeared in a
couple net drivers was correct at the time, so I didn't feel I had the
justification to reject it, but it still gave me a bad feeling.
I think the scenario you outline is an illustration of the approach's
fragility: disable_irq() is a heavy hammer that originated with INTx,...
| Sep 28, 10:47 pm 2007 |
| Stephen Hemminger | Re: MSI interrupts and disable_irq
On Fri, 28 Sep 2007 22:47:16 -0400
I'll try and clean it up if the author doesn't get to it first.
--
Stephen Hemminger <shemminger@linux-foundation.org>
-
| Sep 28, 11:08 pm 2007 |
| Wolfgang Erig | regression in 2.6.23-rc8 - power off failed on old laptop
Hi,
the latest kernel does not power off my old laptop.
2.6.22 succeeded
2.6.23-rc8 failed
$ git bisect good
Bisecting: 0 revisions left to test after this
[626073132b381684c4983e0d911e9aceb32e2cbc] Assembly header and main routine for new x86 setup code
Which more info is needed?
Wolfgang
-
| Sep 28, 9:03 pm 2007 |
| H. Peter Anvin | Re: regression in 2.6.23-rc8 - power off failed on old laptop
Okay, I just went back and looked at it... this particular checkin had
*zero* code impact (code not yet turned on), as did any of the checkins
immediately surrounding it.
Since your other email points to
f216cc3748a3a22c2b99390fddcdafa0583791a2, which is a *much* later
checkin, and which seems to actually have something to do with power
states, that the above is a red herring?
-hpa
-
| Sep 28, 11:09 pm 2007 |
| H. Peter Anvin | Re: regression in 2.6.23-rc8 - power off failed on old laptop
A description of the system, your .config file, kernel messages (old and
new).
Also see http://marc.info/?i=46FD802D.2030804@zytor.com for a highly
useful debugging step, especially if you can dump both before & after.
-hpa
-
| Sep 28, 9:11 pm 2007 |
| Wolfgang Erig | regression in 2.6.23-rc8 - power off failed
Hi,
the latest kernel does not power off my system.
2.6.22 succeeded
2.6.23-rc8 failed
$ git bisect bad
Bisecting: 0 revisions left to test after this
[f216cc3748a3a22c2b99390fddcdafa0583791a2] ACPI: suspend: consolidate handling of Sx states.
Which more info is needed?
Wolfgang
-
| Sep 28, 8:54 pm 2007 |
| Frans Pop | regression in 2.6.23-rc8 - power off failed
This is a known regression in rc8. See this mail and thread for details:
http://lkml.org/lkml/2007/9/25/239
The issue has already been fixed in Linus' git tree.
Please try again with that, or apply the patches included in the posts
referenced in the message linked above.
Cheers,
Frans Pop
-
| Sep 28, 10:59 pm 2007 |
| Frans Pop | regression in 2.6.23-rc8 - power off failed
My apologies for the two bogus addresses in the "To" of my previous
message. Script error, won't happen again.
Frans Pop
-
| Sep 28, 11:29 pm 2007 |
| H. Peter Anvin | Re: regression in 2.6.23-rc8 - power off failed
OK, so which one is the bad one?
-hpa
-
| Sep 28, 11:05 pm 2007 |
| Rob Landley | [PATCH] Documentation/x86_64/00-INDEX
From: Rob Landley <rob@landley.net>
Add Documentation/x86_64/00-INDEX
Signed-off-by: Rob Landley <rob@landley.net>
---
x86_64/00-INDEX | 14 ++++++++++++++
1 file changed, 14 insertions(+)
--- /dev/null 2007-04-23 10:59:00.000000000 -0500
+++ Documentation/x86_64/00-INDEX 2007-09-28 19:40:56.000000000 -0500
@@ -0,0 +1,14 @@
+00-INDEX
+ - This file
+boot-options.txt
+ - AMD64-specific boot options.
+cpu-hotplug-spec
+ - Firmware support for CPU hotplug under Linux/x86-64
...
| Sep 28, 8:44 pm 2007 |
| Rob Landley | Re: [PATCH] Documentation/x86_64/00-INDEX (right path this t...
From: Rob Landley <rob@landley.net>
Add Documentation/x86_64/00-INDEX
Signed-off-by: Rob Landley <rob@landley.net>
---
Trying again with the right path...
x86_64/00-INDEX | 14 ++++++++++++++
1 file changed, 14 insertions(+)
--- /dev/null 2007-04-23 10:59:00.000000000 -0500
+++ b/Documentation/x86_64/00-INDEX 2007-09-28 19:40:56.000000000 -0500
@@ -0,0 +1,14 @@
+00-INDEX
+ - This file
+boot-options.txt
+ - AMD64-specific boot options.
+cpu-hotplug-spec
+ - Firmware su...
| Sep 28, 8:53 pm 2007 |
| Rob Landley | [PATCH] Remove nonstandard line break from Documentation/pow...
From: Rob Landley <rob@landley.net>
Remove nonstandard line break from Documentation/powerpc/00-INDEX
Signed-off-by: Rob Landley <rob@landley.net>
---
This is the only instance of a newline in a 00-INDEX file description, and
it confuses my 00-INDEX > index.html converter.
Documentation/powerpc/00-INDEX | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -r dc28e4e17791 Documentation/powerpc/00-INDEX
--- a/Documentation/powerpc/00-INDEX Wed Sep 26 15:52:17 2007...
| Sep 28, 8:25 pm 2007 |
| Rob Landley | [PATCH]: Documentation/vm/00-INDEX
From: Rob Landley <rob@landley.net>
Add a 00-INDEX file for Documentation/vm
Signed-off-by: Rob Landley <rob@landley.net>
---
Documentation/vm/00-INDEX | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
--- /dev/null 2007-04-23 10:59:00.000000000 -0500
+++ kdocs/Documentation/vm/00-INDEX 2007-09-28 19:15:48.000000000 -0500
@@ -0,0 +1,20 @@
+00-INDEX
+ - This file
+balance
+ - Zone balancing (making sure each memory zone has enough free pages).
+hugetlbpage.txt
+...
| Sep 28, 8:19 pm 2007 |
| Maarten Bressers | Re: [PATCH] Fix compiler warnings for 2.6.23-rc8 on x86_64
On Fri, 28 Sep 2007 15:49:26 -0700
Greg, thank you for your reply. It seems I'm out of my league here, I
just thought I could quickly fix two compiler warnings, obviously this
is not the case. I've read the documentation, but I don't think I'll be
able to fix this. Sorry for the noise.
Randy, please ignore the other patch I sent you, it's obviously wrong.
-
| Sep 28, 8:04 pm 2007 |
| Greg KH | Re: [PATCH] Fix compiler warnings for 2.6.23-rc8 on x86_64
No problem, and I don't mean to scare you away at all. If you want to
work toward getting rid of all of the callers of the pci_find_slot()
function, that would be best, and then the function can be deleted.
If you have questions on how to do that, feel free to ask.
thanks,
greg k-h
-
| Sep 28, 10:43 pm 2007 |
| Kyle McMartin | [COMPAT] Add compat_merge64 helper
To be used when endianness matters for argument ordering when reassembling
a 64-bit value out of two register halves.
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
---
include/linux/compat.h | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/include/linux/compat.h b/include/linux/compat.h
index 0e69d2c..07bcc3c 100644
--- a/include/linux/compat.h
+++ b/include/linux/compat.h
@@ -267,5 +267,14 @@ asmlinkage long compat_sys_signalfd(int ufd,
asmlinkage lon...
| Sep 28, 6:33 pm 2007 |
| Arnd Bergmann | Re: [COMPAT] Add compat_merge64 helper
Looks good, if we can guarantee that
1. Byte order matches the order in which 64 bit arguments are split
in system call conventions on all platforms.
2. Every user of compat_merge64() includes asm/byteorder.h
Both should be easy to prove, but I'm not convinced until someone
actually does it.
Arnd <><
-
| Sep 28, 7:38 pm 2007 |
| Kyle McMartin | Re: [COMPAT] Add compat_merge64 helper
I checked powerpc, sparc, and mips, which are (besides parisc) the only
64-bit with 32-bit userspace big endian architectures that I could think
Cheers,
Kyle
-
| Sep 28, 8:01 pm 2007 |
| Arnd Bergmann | Re: [COMPAT] Add compat_merge64 helper
s390 is big-endian as well, and while it does have really weird C calling
conventions for 64 bit arguments in 32 bit mode, these do not affect the
system call ABI, so we should be fine here.
ia64 and x86_64 are obviously little-endian, and I double-checked that they
work with this logic.
Arnd <><
-
| Sep 28, 7:52 pm 2007 |
| Kyle McMartin | Re: [COMPAT] Add compat_merge64 helper
Ah, no CONFIG_COMPAT on sh64 anyways.
-
| Sep 28, 8:02 pm 2007 |
| Kyle McMartin | [PATCH] Generic compat_sys_fallocate
Basically everyone is using the same sys32_fallocate. Delete a whole bunch of
archdep code and move the compat wrapper to fs/compat.c
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
---
arch/mips/kernel/linux32.c | 7 -------
arch/mips/kernel/scall64-o32.S | 2 +-
arch/powerpc/kernel/sys_ppc32.c | 7 -------
arch/sparc64/kernel/sys_sparc32.c | 6 ------
arch/x86_64/ia32/ia32entry.S | 2 +-
arch/x86_64/ia32/sys_ia32.c | 7 -------
fs/compat.c ...
| Sep 28, 6:33 pm 2007 |
| Robert Hancock | Re: General slowness with using 64Gb HIGHMEM option on 32-bi...
Make sure your BIOS is up to date. If so, post your dmesg output and the
contents of /proc/mtrr. There are a number of Intel boards which
have/had BIOS bugs where the BIOS didn't set up the MTRRs to mark all
RAM as write-back. This results in the last bit of memory being
uncacheable and causes a major performance drop.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
-
| Sep 28, 7:40 pm 2007 |
| Maarten Bressers | Re: [PATCH] Fix compiler warnings for 2.6.23-rc8 on x86_64
Sorry Randy, I accidentally deleted the subject line, so I sent it again.
On Fri, 28 Sep 2007 14:48:53 -0700
I'm attaching a patch here that I think will clean up all uses of
pci_find_device(), except one in drivers/net/skfp/drvfbi.c:1248. I'm not
sure what to make of that one, do you have any suggestions?
diff --git a/drivers/isdn/hisax/avm_pci.c b/drivers/isdn/hisax/avm_pci.c
index b04a178..86e0236 100644
--- a/drivers/isdn/hisax/avm_pci.c
+++ b/drivers/isdn/hisax/avm_pci.c
@@ -789,8 +7...
| Sep 28, 7:02 pm 2007 |
| Dave Hansen | [RFC][PATCH] make module refcounts use percpu_counters
Module refcounts currently use a percpu counter stored
in the 'struct module'. However, we also have a more
generic implementation that does stuff like handle
hotplug cpus.
I'm not actually all that convinced that this refcount
actually does a lot of good, with cpus racing bumping
the counters at the same time that they're being
summed up. But, it certainly isn't any worse than
what was there before. We also get any hotplug-cpu
compatible changes that happen to percpu_counters for
free.
...
| Sep 28, 7:00 pm 2007 |
| Maarten Bressers | On Fri, 28 Sep 2007 14:48:53 -0700
I'm attaching a patch here that I think will clean up all uses of
pci_find_device(), except one in drivers/net/skfp/drvfbi.c:1248. I'm not
sure what to make of that one, do you have any suggestions?
diff --git a/drivers/isdn/hisax/avm_pci.c b/drivers/isdn/hisax/avm_pci.c
index b04a178..86e0236 100644
--- a/drivers/isdn/hisax/avm_pci.c
+++ b/drivers/isdn/hisax/avm_pci.c
@@ -789,8 +789,8 @@ setup_avm_pcipnp(struct IsdnCard *card)
}
#endif
#ifdef CONFIG_PCI
- if ((dev_avm = pci_find_devi...
| Sep 28, 6:49 pm 2007 |
| Randy Dunlap | Re: On Fri, 28 Sep 2007 14:48:53 -0700
It's more than a simple s/pci_find_device/pci_get_device/g patch.
pci_find_device() didn't use any reference counting, but pci_get_device()
does. Then when the resource use is finished, it must be released
--
~Randy
Phaedrus says that Quality is about caring.
-
| Sep 28, 7:06 pm 2007 |
| Justin Piszcz | Re: Truncated Filesystem
Including LKML on this one as it may be a partition size limit? Sdc1 is
not 11TB.
Justin.
-
| Sep 28, 6:22 pm 2007 |
| Eric Sandeen | Re: Truncated Filesystem
Yup saw the same thing:
(1957867653*1024)/1024/1024/1024/1024 = 1.82T
I'm afraid you don't have a truncated filesystem, you have a truncated
block device. I'm afraid this is not an xfs problem... you need to
figure out what happened to sdc1 (for example, why doesn't it extend to
the end of sdc?)
-Eric
-
| Sep 28, 7:36 pm 2007 |
| H. Peter Anvin | Re: Truncated Filesystem
What kind of partition table is it? MS-DOS partition tables have a 2 TB
limit.
-hpa
-
| Sep 28, 8:00 pm 2007 |
| Benjamin Carr | Re: Truncated Filesystem
Hadn't thought of that, doesn't look good.
-Ben
sudo fdisk -l /dev/sdc1
benc's password:
Disk /dev/sdc1: 2004.8 GB, 2004856477184 bytes
255 heads, 63 sectors/track, 243743 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Disk /dev/sdc1 doesn't contain a valid partition table
-
| Sep 28, 8:49 pm 2007 |
| Joshua Baker-LePain | Re: Truncated Filesystem
Issue number one -- don't use fdisk, as it doesn't support devices that
big. Use parted instead:
parted /dev/sdc
mklabel gpt
mkpart primary ext2 0 11TB
quit
where you may have to sub some other value for the "11TB" in the mkpart
line -- I forget the exact syntax.
--
Joshua Baker-LePain
QB3 Shared Cluster Sysadmin
UCSF
-
| Sep 28, 9:49 pm 2007 |
| Benjamin Carr | Re: Truncated Filesystem
climate:~ benc$ sudo parted /dev/sdc check 1
Warning: Partition 1 is 2005GB, but the file system is 13TB.
Yeah, that is a problem.
-
| Sep 28, 10:15 pm 2007 |
| H. Peter Anvin | Sep 28, 8:59 pm 2007 | |
| Benjamin Carr | Re: Truncated Filesystem
yeah, long day:
Disk /dev/sdc: 12999.9 GB, 12999988871168 bytes
255 heads, 63 sectors/track, 1580491 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/sdc1 1 243744 1957867653+ 83 Linux
-
| Sep 28, 9:06 pm 2007 |
| H. Peter Anvin | Re: Truncated Filesystem
Looks like an MS-DOS partition table, indeed.
-hpa
-
| Sep 28, 9:16 pm 2007 |
| Peter Lieven | PATCH: tcp rfc 2385 security/bugfix for sparc64
TCP MD5 signatures on sparc64 (big-endian) completely fail on current
kernel releases in interoperability with Cisco/Foundry or other
little-endian linux systems.
The root cause is a cast in the return statement of tcp_v4_md5_do_lookup,
where a tcp4_md5sig_key is casted onto tcp_md5sig_key without proper
conversion. On little-endian systems the upper 8 bits are cut of which
yields the expected behaviour. However, on big-endian systems (like
sparc64) only the most significant 8 bits are preserved. S...
| Sep 28, 4:42 pm 2007 |
| David Miller | Re: PATCH: tcp rfc 2385 security/bugfix for sparc64
From: "Peter Lieven" <pl@dlh.net>
I'll have to apply this patch by hand because your email client
Thanks again.
-
| Sep 28, 5:20 pm 2007 |
| David Miller | Re: PATCH: tcp rfc 2385 security/bugfix for sparc64
From: David Miller <davem@davemloft.net>
Actually, I think I'm going to put in a slightly different
fix.
If tcp4_md5sig_key and tcp6_md5sig_key have to begin with exacytly
tcp_md5sig_key's only two members, we should fully tell this
explicitly to the compiler and remove those ugly casts.
The casts are the real bug.
Here is the patch I will use after some testing:
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 185c7ec..54053de 100644
--- a/include/net/tcp.h
+++ b/include/...
| Sep 28, 5:30 pm 2007 |
| Erez Zadok | [PATCH] 0/3 coding standards documentation/code updates
The following is a series of patches related to coding standards. The first
patch updates the CodingStandards document with respect to printk debugging
and un/likely use; the second patch updates the usage string for
checkpatch.pl; the third patch introduces a new small perl script that can
be used to check coding-standards compliance on multiple source files. This
new script, called check-coding-standards.pl, produces output in a standard
compiler-error format, which can be parsed by assorted too...
| Sep 28, 5:31 pm 2007 |
| Erez Zadok | [PATCH 1/3] CodingStyle updates
1. Updates chapter 13 (printing kernel messages) to expand on the use of
pr_debug()/pr_info(), what to avoid, and how to hook your debug code with
kernel.h.
2. New chapter 19, branch prediction optimizations, discusses the whole
un/likely issue.
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: Kyle Moffett <mrmacman_g4@mac.com>
Cc: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Adrian Bunk <bunk@kernel.org>
Cc: roel <12o3l@tiscali.nl>
Signed-off-by: Erez Za...
| Sep 28, 5:32 pm 2007 |
| Randy Dunlap | Re: [PATCH 1/3] CodingStyle updates
A few comments below...
---
~Randy
Phaedrus says that Quality is about caring.
-
| Sep 28, 5:46 pm 2007 |
| Erez Zadok | [PATCH 3/3] New script to check coding-style compliance on m...
The script calls checkpatch.pl on each file, and formats any error messages
to comply with standard compiler error messages:
file_name:line_number:error_message
This is particularly useful when run from within a text editor which can
parse these error messages and show the user a buffer with the file in
question, placing the cursor on the offending line (e.g., Emacs's "M-x
next-error" command, bound by default to C-x `).
Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
scripts/check-...
| Sep 28, 5:32 pm 2007 |
| Erez Zadok | [PATCH 2/3] Update usage string for checkpatch.pl
Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
scripts/checkpatch.pl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dae7d30..ecbb030 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -33,6 +33,7 @@ if ($#ARGV < 0) {
print "version: $V\n";
print "options: -q => quiet\n";
print " --no-tree => run without a kernel tree\n";
+ print " --no-signoff => ...
| Sep 28, 5:32 pm 2007 |
| Maarten Bressers | [PATCH] Fix compiler warnings for 2.6.23-rc8 on x86_64
This (trivial) patch fixes two compiler warnings for 2.6.23-rc8 on x86_64,
use of deprecated function pci_find_device() and a section mismatch.
Build log and .config file included.
Signed-off by: Maarten Bressers <mbres@gentoo.org>
diff --git a/arch/x86_64/kernel/smpboot.c b/arch/x86_64/kernel/smpboot.c
index 32f5078..7c872df 100644
--- a/arch/x86_64/kernel/smpboot.c
+++ b/arch/x86_64/kernel/smpboot.c
@@ -532,7 +532,7 @@ struct create_idle {
int cpu;
};
-void do_fork_idle(struct...
| Sep 28, 4:56 pm 2007 |
| Greg KH | Re: [PATCH] Fix compiler warnings for 2.6.23-rc8 on x86_64
This is not a trivial patch, it changes the behavior of the code and is
buggy.
Please read the documentationfor pci_get_device() on how to use it
properly. It can not be used in pci_find_slot() as the reference
counting will be all wrong. You need to just work to get rid of
pci_find_slot() and then remove the whole function to get rid of the
What about the modules that want to use these functions? Are they all
now gone? If so, just drop the whole function.
thanks,
greg k-h
-
| Sep 28, 6:49 pm 2007 |
| Randy Dunlap | Re: [PATCH] Fix compiler warnings for 2.6.23-rc8 on x86_64
Please include the text from section mismatch warnings in the patch
There are still about 30 and 14 respetively users of pci_find_devic()
---
~Randy
Phaedrus says that Quality is about caring.
-
| Sep 28, 5:48 pm 2007 |
| Brian King | Re: [PATCH 7/8] scsi: megaraid_sas - support for poll_mode_i...
I'm not sure what to think of this patch, but it seems like most of the code to
do something like this might be better off in scsi core so that other LLDDs can
also make use of it.
What is the problem that you are trying to solve with this patch? Are you
trying to do something like NAPI where you are getting too many interrupts
so this is a performance problem, or is this to work around some hardware
problem of interrupts not working properly in certain configurations?
Incidentally, there was a...
| Sep 28, 5:58 pm 2007 |
| Santiago Garcia Mantinan | vga text console not working on 2.6.23-rc8
Hi!
I have just compiled a 2.6.23-rc8 using the config from my 2.6.22 as a basis
and I came out with a not working (almost black) vga text console.
This is what I'm getting on my logs:
Console: colour dummy device 80x25
console [tty0] enabled
Instead of the old:
Console: colour VGA+ 80x25
The options related to the console on my config are these:
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_HW_CONSOLE=y
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_CONSOLE=y
CONFIG_SERIAL_CORE=y
CONFIG_SERI...
| Sep 28, 4:03 pm 2007 |
| Antonino A. Daplas | Re: vga text console not working on 2.6.23-rc8
Also insert this in drivers/video/console/vgacon.c as the first
statement of vgacon_startup()
printk("vgacon: ORIG_VIDEO_ISVGA %x ORIG_VIDEO_MODE %x ORIG_VIDEO_LINES
%x ORIG_VIDEO_COLS %x\n", ORIG_VIDEO_ISVGA, ORIG_VIDEO_MODE,
ORIG_VIDEO_LINES, ORIG_VIDEO_COLS);
Tony
-
| Sep 28, 8:41 pm 2007 |
| previous day | today | next day |
|---|---|---|
| September 27, 2007 | September 28, 2007 | September 29, 2007 |
| Thomas Gleixner | Re: Linux 2.6.21-rc1 |
| Tarkan Erimer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| James Bottomley | [Ksummit-2008-discuss] Fixing the Kernel Janitors project |
| James Morris | Re: LSM conversion to static interface |
git: | |
| Natalie Protasevich | [BUG] New Kernel Bugs |
| Christoph Hellwig | Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2] |
| Linus Torvalds | Re: [GIT]: Networking |
| Jarek Poplawski | [PATCH take 2] pkt_sched: Protect gen estimators under est_lock. |
