Home » Mailing list archives » linux-kernel » 2007 » September » 28

Re: [4/4] mthca: allow setting "dmabarrier" on user-allocated memory

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier <rdreier@...>
To: <akepner@...>
Cc: Grant Grundler <grundler@...>, Jesse Barnes <jbarnes@...>, Jes Sorensen <jes@...>, Randy Dunlap <randy.dunlap@...>, James Bottomley <James.Bottomley@...>, <linux-kernel@...>
Subject: Re: [4/4] mthca: allow setting "dmabarrier" on user-allocated memory
Date: Friday, September 28, 2007 - 3:50 pm

Sorry for not mentioning this earlier, but this patch should really be
two (or more) patches: one to add dmabarrier support to the core user
memory stuff in drivers/infiniband, and a second one to add support to
mthca (and more patches to add support to mlx4, cxgb3, etc, etc).

 > + * @dmabarrier: set "dmabarrier" attribute on this memory, if necessary 

Nit: just delete the "if necessary" since I don't think it makes
things clearer (and actually doesn't make much sense in this context)

Other than that this look fine to me, and I'm ready to merge it once
the necessary core DMA stuff is settled.

 - R.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[4/4] mthca: allow setting "dmabarrier" on user-allocated me..., , (Thu Sep 27, 9:13 pm)
Re: [4/4] mthca: allow setting "dmabarrier" on user-allocate..., Roland Dreier, (Fri Sep 28, 3:50 pm)
Re: [4/4] mthca: allow setting "dmabarrier" on user-allocate..., , (Tue Oct 2, 9:02 pm)