Re: [PATCH] update checkpatch.pl to version 0.10

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andy Whitcroft <apw@...>
Cc: Ingo Molnar <mingo@...>, Andrew Morton <akpm@...>, Randy Dunlap <rdunlap@...>, Joel Schopp <jschopp@...>, <linux-kernel@...>
Date: Friday, September 28, 2007 - 12:51 pm

Hi Andy.

The original purpose was to catch the most tivial coding style errors.
But then people started to be far too innovative and we now ended
up with a checkpatch that try to check for every lillte glory detail.

It would be much preferable to have a checkpatch - and that may be an
incarnation of the current one or a new one.
What it should do would be to catch the trivialities that we see happens
in many patch submissions like:

a) wrong patch format (-p1, unified diff)
b) Whitespace versus tabs
c) PascalCasing in new functions
d) excessive line length
e) C99 comments '//' (not that I see why they are banned)

and maybe a few more trivial chacks.

This would benefit from a very low false-positive rate and it could then
be used as a patch-bot.

As it is now where it tries to check for everything and a bit more
it generates too much noise so a patch-bot usage is not possible.
And users get annoyed by the excessive output.

If we then have the same script that in a -pedantic mode generate
more noise - fine. But leave the default simple.

	Sam
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Wed Sep 12, 11:00 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 4:40 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 5:52 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andrew Morton, (Fri Sep 28, 5:01 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 5:44 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 5:22 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 5:39 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 6:00 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Sam Ravnborg, (Fri Sep 28, 12:51 pm)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 6:49 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Oct 5, 1:56 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 9:21 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andrew Morton, (Fri Sep 28, 1:46 pm)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Sat Sep 29, 5:22 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Randy Dunlap, (Fri Sep 28, 1:26 pm)
Re: [PATCH] update checkpatch.pl to version 0.10, Joel Schopp, (Fri Sep 28, 11:50 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Pekka Enberg, (Fri Sep 28, 9:37 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 10:02 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Christian Borntraeger, (Fri Sep 28, 6:46 am)
Re: [PATCH] update checkpatch.pl to version 0.10, WANG Cong, (Fri Sep 28, 7:03 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Jan Engelhardt, (Fri Sep 28, 10:19 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Randy Dunlap, (Fri Sep 28, 12:57 pm)