Re: [PATCH] update checkpatch.pl to version 0.10

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Andy Whitcroft <apw@...>, Randy Dunlap <rdunlap@...>, Joel Schopp <jschopp@...>, <linux-kernel@...>
Date: Friday, September 28, 2007 - 5:44 am

* Andrew Morton <akpm@linux-foundation.org> wrote:


well, the two variants is:

	max_load = this_load = total_load = total_pwr = 0;

	max_load = 0;
	this_load = 0;
	total_load = 0;
	total_pwr = 0;

and the first one is more readable and more compact. (as long as the 
conceptual 'type' of the variables is the same - which it is in this 
case.)

anyway, this is something where reasonable people might disagree, and a 
tool should not force it one way or another. And this is the second time 
i raised this very example and Andy ignored my feedback and failed to 
notice the structural problem behind it (that a tool should only warn by 
default if it is _sure_ that there is a problem - otherwise the tool 
cannot be used for effective [i.e. automated] quality control), so i'm 
raising this point again, in a slightly more irritated tone ;-)

	Ingo
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Wed Sep 12, 11:00 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 4:40 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 5:52 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andrew Morton, (Fri Sep 28, 5:01 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 5:44 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 5:22 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 5:39 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 6:00 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Sam Ravnborg, (Fri Sep 28, 12:51 pm)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Sep 28, 6:49 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Ingo Molnar, (Fri Oct 5, 1:56 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 9:21 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andrew Morton, (Fri Sep 28, 1:46 pm)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Sat Sep 29, 5:22 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Randy Dunlap, (Fri Sep 28, 1:26 pm)
Re: [PATCH] update checkpatch.pl to version 0.10, Joel Schopp, (Fri Sep 28, 11:50 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Pekka Enberg, (Fri Sep 28, 9:37 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Andy Whitcroft, (Fri Sep 28, 10:02 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Christian Borntraeger, (Fri Sep 28, 6:46 am)
Re: [PATCH] update checkpatch.pl to version 0.10, WANG Cong, (Fri Sep 28, 7:03 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Jan Engelhardt, (Fri Sep 28, 10:19 am)
Re: [PATCH] update checkpatch.pl to version 0.10, Randy Dunlap, (Fri Sep 28, 12:57 pm)