Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Dave Hansen <haveblue@...>, <hch@...>, <laurent.riffard@...>, <linux-kernel@...>, <linux-fsdevel@...>, <reiserfs-devel@...>
Date: Friday, September 28, 2007 - 3:16 am

On Thu, Sep 27, 2007 at 02:51:25PM -0700, Andrew Morton wrote:

Yeah, I was looking at mainline.


I'd rather avoid the paramater removal for now, that makes it less
entangle, and it's an unrelated cleanup anyway.

Btw, there's more abuse of this sort in reiserfs.  Various other places
in xattr.c call dentry_open directly without the vfsmount aswell.  And
handling of an external journal uses filp_open which is similarly stupid,
it should use open_bdev_excl like xfs or the generic code to open the
main filesystem blockdevice.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.23-rc8-mm2, Andrew Morton, (Thu Sep 27, 5:22 am)
Re: 2.6.23-rc8-mm2, Matt Mackall, (Tue Oct 9, 1:49 pm)
Re: 2.6.23-rc8-mm2 - PowerPC link failure at arch/powerpc/ke..., Kamalesh Babulal, (Sun Sep 30, 12:10 am)
Re: 2.6.23-rc8-mm2, , (Sat Sep 29, 10:26 pm)
Re: 2.6.23-rc8-mm2, Andrew Morton, (Sun Sep 30, 4:50 am)
Re: 2.6.23-rc8-mm2, , (Mon Oct 1, 12:12 pm)
Re: 2.6.23-rc8-mm2, Rafael J. Wysocki, (Sun Sep 30, 4:01 pm)
Re: 2.6.23-rc8-mm2, , (Mon Oct 1, 1:12 pm)
Re: 2.6.23-rc8-mm2, Dave Young, (Sat Sep 29, 5:37 am)
Re: 2.6.23-rc8-mm2, Greg KH, (Sat Sep 29, 11:19 am)
Re: 2.6.23-rc8-mm2, Dave Young, (Mon Oct 8, 2:43 am)
Re: 2.6.23-rc8-mm2, , (Sun Sep 30, 1:18 am)
Re: 2.6.23-rc8-mm2, Dave Young, (Sat Sep 29, 9:29 pm)
/proc/net/ bad hard links count [Was: 2.6.23-rc8-mm2], Jiri Slaby, (Fri Sep 28, 12:30 pm)
Re: /proc/net/ bad hard links count [Was: 2.6.23-rc8-mm2], Eric W. Biederman, (Fri Sep 28, 1:03 pm)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Cedric Le Goater, (Fri Sep 28, 11:42 am)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Ilpo Järvinen, (Fri Sep 28, 3:10 pm)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Ilpo Järvinen, (Sat Sep 29, 8:44 am)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Cedric Le Goater, (Sat Sep 29, 10:55 am)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Ilpo Järvinen, (Sat Sep 29, 4:49 pm)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Cedric Le Goater, (Mon Oct 1, 5:26 am)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Ilpo Järvinen, (Tue Oct 2, 6:26 am)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Ilpo Järvinen, (Tue Oct 2, 4:06 pm)
Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING, Ilpo Järvinen, (Tue Oct 2, 5:48 pm)
Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set, Laurent Riffard, (Thu Sep 27, 3:18 pm)
Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set, Andrew Morton, (Thu Sep 27, 3:48 pm)
Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set, Christoph Hellwig, (Thu Sep 27, 4:26 pm)
Re: [RFC][PATCH] make reiserfs stop using 'struct file' for ..., Christoph Hellwig, (Thu Sep 27, 5:04 pm)
Re: [RFC][PATCH] make reiserfs stop using 'struct file' for ..., Christoph Hellwig, (Fri Sep 28, 3:16 am)
[RFC][PATCH] stop abusing filp_open in reiserfs journal code, Christoph Hellwig, (Fri Sep 28, 3:29 am)
Re: 2.6.23-rc8-mm2: BUG near reiserfs_xattr_set, Dave Hansen, (Thu Sep 27, 4:05 pm)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Rafael J. Wysocki, (Thu Sep 27, 11:19 am)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Rafael J. Wysocki, (Thu Sep 27, 11:59 am)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Sam Ravnborg, (Thu Sep 27, 12:53 pm)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Randy Dunlap, (Thu Sep 27, 1:33 pm)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Sam Ravnborg, (Thu Sep 27, 3:19 pm)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Rafael J. Wysocki, (Thu Sep 27, 3:48 pm)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Randy Dunlap, (Thu Sep 27, 3:37 pm)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Rafael J. Wysocki, (Thu Sep 27, 4:01 pm)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Thomas Gleixner, (Thu Sep 27, 11:49 am)
Re: 2.6.23-rc8-mm2: problems on HP nx6325, Rafael J. Wysocki, (Fri Sep 28, 5:31 pm)
Re: 2.6.23-rc8-mm2 - drivers/net/ibm_newemac/mal - broken, Kamalesh Babulal, (Thu Sep 27, 6:52 am)