login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
September
»
27
Re: PCI: Fix boot-time hang on G31/G33 PC
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Greg KH <greg@...>
To: Kok, Auke <auke-jan.h.kok@...>
Cc: Ivan Kokshaysky <ink@...>, Jesse Barnes <jesse.barnes@...>, <linux-pci@...>, Matthew Wilcox <matthew@...>, <linux-kernel@...>, Robert Hancock <hancockr@...>, Li, Shaohua <shaohua.li@...>, Andrew Morton <akpm@...>
Subject:
Re: PCI: Fix boot-time hang on G31/G33 PC
Date: Thursday, September 27, 2007 - 7:13 pm
On Thu, Sep 27, 2007 at 11:36:32AM -0700, Kok, Auke wrote:
quoted text
> Ivan Kokshaysky wrote: > > On Wed, Sep 26, 2007 at 03:20:40PM -0700, Jesse Barnes wrote: > >> Ivan, your concern is about disabling things like interrupt controllers > >> and power management chips during probe right? You're right that doing > >> that could cause problems if we get and interrupt or PMU event at just > >> the wrong time, but that could just as easily happen if decode was > >> still enabled but the BAR had a bogus address programmed (as it would > >> during probing). > > > > Yes, nobody is arguing that moving the BAR around is unsafe, but generally > > it's the less of two evils. > > > > The major problem here is that with IO and MEM bits cleared in the command > > register you disable *all* address decoders on the device, not just ranges > > that have respective BARs. At least this behaviour is required by PCI spec. > > Examples: > > - legacy VGA IO and memory (no corresponding BARs); > > - base/limit registers of P2P bridge; > > - PMU and SMBus registers (sort of normal BARs, but hidden elsewhere > > in the config space); > > - IDE legacy mode registers; > > - IO-APIC registers (typically sort of read-only BAR). > > > > For all of these address ranges our current BAR probe is effectively > > a no-op, but disable/re-enable clearly isn't. > > > >> Ultimately, I don't care much one way or another as long as we can get > >> the desktop platforms fixed somehow. I think disabling decode is the > >> most correct way of doing this, but I'm open to other solutions (this > >> is the only patch I've seen though that's been tested to solve the > >> problem). > > > > There are two other solutions: one is to disable decode selectively, > > only on devices or systems where it's necessary and known to be safe. > > I've posted a patch which introduces "disable_while_probe" pci_dev field > > for that purpose. > > Another one is to delay mmconfig probe until after the PCI probe is done, > > as Matthew suggested, and Robert confirmed that it's feasible. > > > for everyone who's using this quirk or has the same boot issue: I just confirmed > that the new dg33tl bios update v0287 (released 9/20) fixes the boot issue for my > systems. I encourage everyone to update their BIOS image and see if this works.
Thanks for letting us know. So, another reason to drop this patch :) thanks, greg k-h -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] Fix boot-time hang on G31/G33 PC
, Matthew Wilcox
, (Sat Aug 25, 9:55 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Greg KH
, (Wed Sep 26, 5:18 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Jesse Barnes
, (Wed Sep 26, 5:55 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Greg KH
, (Wed Sep 26, 5:56 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Jesse Barnes
, (Wed Sep 26, 6:20 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Ivan Kokshaysky
, (Thu Sep 27, 10:31 am)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Kok, Auke
, (Thu Sep 27, 2:36 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Greg KH
, (Thu Sep 27, 7:13 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Vitaliy Gusev
, (Fri Oct 12, 10:26 am)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Kok, Auke
, (Fri Oct 12, 1:07 pm)
Re: PCI: Fix boot-time hang on G31/G33 PC
, Robert Hancock
, (Wed Sep 26, 7:04 pm)
Re: [PATCH] Fix boot-time hang on G31/G33 PC
, Grant Grundler
, (Tue Aug 28, 1:59 pm)
Re: [PATCH] Fix boot-time hang on G31/G33 PC
, Grant Grundler
, (Tue Aug 28, 2:28 pm)
Re: [PATCH] Fix boot-time hang on G31/G33 PC
, Robert Hancock
, (Sun Aug 26, 12:24 am)
Re: [PATCH] Fix boot-time hang on G31/G33 PC
, Matthew Wilcox
, (Sun Aug 26, 8:55 am)
Re: [PATCH] Fix boot-time hang on G31/G33 PC
, Matthew Wilcox
, (Sun Aug 26, 10:07 am)
Re: [PATCH] Fix boot-time hang on G31/G33 PC
, Robert Hancock
, (Sun Aug 26, 1:59 pm)
Re: [PATCH] Fix boot-time hang on G31/G33 PC
, Jesse Barnes
, (Tue Aug 28, 1:22 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Justin C. Sherrill
Re: dragonflybsd.org website link?
David Woodhouse
Re: -mm merge plans for 2.6.23
Greg Kroah-Hartman
[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Eric Sandeen
Re: [RFC] Heads up on sys_fallocate()
git
:
linux-netdev
:
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Patrick McHardy
[NET_SCHED 01/15]: sch_atm: fix format string warning
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
693 guests
online.
Online users
makeup13
earlehensley35
Syndicate