Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Brett Warden <brett.warden@...>

Cc: Ray Lee <ray-lk@...>, Randy Dunlap <randy.dunlap@...>, <linux-kernel@...>, <trivial@...>

Subject: Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

Date: Thursday, September 27, 2007 - 5:29 pm

On Thu, 27 Sep 2007 12:28:31 -0700
"Brett Warden" <brett.warden@gmail.com> wrote:

quoted text> Fixes use of parport_write_control() to match the newer interface that
> requires explicit parport_data_reverse() and parport_data_forward()
> calls. This eliminates the following error message and restores the
> original intended behavior:

Looks good

quoted text> parport0 (bw-qcam): use data_reverse for this!
> 
> Also increases threshold in qc_detect() from 300 to 400, as my camera
> often results in a count of approx 330. Added a kernel error message
> to indicate detection failure.

Likewise

quoted text> Signed-off-by: Brett T. Warden <brett.warden@gmail.com>

Acked-by: Alan Cox <alan@redhat.com>
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] bw-qcam: use data_reverse instead of manually poking..., Brett Warden, (Wed Sep 26, 3:12 pm)

Re: [PATCH] bw-qcam: use data_reverse instead of manually po..., Randy Dunlap, (Wed Sep 26, 5:00 pm)

Re: [PATCH] bw-qcam: use data_reverse instead of manually po..., Ray Lee, (Wed Sep 26, 3:43 pm)

Re: [PATCH] bw-qcam: use data_reverse instead of manually po..., Brett Warden, (Wed Sep 26, 4:06 pm)

Re: [PATCH] bw-qcam: use data_reverse instead of manually po..., Ray Lee, (Wed Sep 26, 5:00 pm)

Re: [PATCH] bw-qcam: use data_reverse instead of manually po..., Brett Warden, (Wed Sep 26, 5:43 pm)

Re: [PATCH] bw-qcam: use data_reverse instead of manually po..., Brett Warden, (Thu Sep 27, 3:28 pm)

Re: [PATCH] bw-qcam: use data_reverse instead of manually po..., Alan Cox, (Thu Sep 27, 5:29 pm)


linux-kernel:
Andrew Morton	Re: Linux 2.6.21-rc4
Andrew Morton	-mm merge plans for 2.6.23
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Balbir Singh	Re: [RFC][PATCH 2/7] RSS controller core
git:

linux-netdev:
Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
David Miller	[GIT]: Networking
Andreas Henriksson	[PATCH 06/12] Remove bogus reference to tc-filters(8) from tc(8) manpage.
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

Online users